Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SRI] enable cors setting #593

Open
Manik-Jain opened this issue Nov 15, 2022 · 2 comments
Open

[SRI] enable cors setting #593

Manik-Jain opened this issue Nov 15, 2022 · 2 comments

Comments

@Manik-Jain
Copy link
Collaborator

Overview

We need to make sure that the CORS is enabled properly before we move to PROD.

Tasks

change in main.ts the cors settings

@Manik-Jain Manik-Jain mentioned this issue Nov 15, 2022
9 tasks
@ognjenkurtic
Copy link
Collaborator

Could you please describe in more detail what does it mean to have CORS enabled properly and how will the completion of this issue be tested?

@Kasshern
Copy link
Collaborator

I think enabled properly here means that the cors setting only allow exactly our expectations within requests - Testing could be run through calls that adhere or not to cors expectations. See more here https://github.com/expressjs/cors#configuration-options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants