-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERC 1497: Evidence Standard #1497
Comments
I have updated the standard by adding Evidence Groupings to the Evidence submission and Dispute creation events. Previously, Evidence was linked directly to a |
Evidence:Is (as a security practice, do not rely on user-provided input, is it ZIP or PDF or HTML Poc||GTFO) MetaEvidence:
Meta MetaEvidence#792 is using human-readable names such as Dispute, Decision, Appeal, Ruling My suggestion would be to replace geeky sounding MetaEvidence with DisputeInfo or ArbitrationInfo or simply Dispute or Arbitration or Case or Matter (legal language) EDIT: Noticed Dispute already exists. MetaEvidence is nothing else than DisputeInfo - definitely merge into one, simplify. EDIT:
If it is not possible to use multihash for the name of the file:
(previous comment about someone replacing content and validating hashes remain valid) EDIT: EDIT: No extension:
I'm literally working on the hackathon project kleros/hackathon#1 and I'm likely to have more thoughts after completion. |
|
Suggestion (assuming we were using IPFS)
If we were using IFPS, we could simply use the hash, instead of the event id... I'm not that good with Ethereum events and accessing their IDs, I thought I'll mention that.
Using EDIT: From my previous comment
I think we need to simplify and agree:
Otherwise, it is not obvious, not clear, error-prone. EDIT:
I would like to submit that JSON to IPFS. I know that library written by @satello - https://archon.readthedocs.io/en/latest/ipfs.html - is accepting the following URI schemes:
(I will probably use ipfs:// with double slash, just like At this stage I'm unsure if CC @clesaege for visibility. |
We cannot assume that Evidence will be hosted using IPFS or another storage that produces/verifies data integrity via hashes. The standard needs to encapsulate all use cases.
We cannot merge
This is for browsers. I chose these formats from here: ipfs/kubo#1678 (comment). This seemed to be the most convincing "standard" for IPFS URIs. Note that the issue is still open so this is subject to change. If you want to continue discussing this we can over at https://github.com/kleros/archon/issues |
The library and the code become de facto a reference implementation. In IPFS filename is the hash Here you suggest using multihash. Prior to reading, I have never heard of multihash. Keccak3 is de facto a hashing standard on Ethereum, whoever is to use the standard, is likely to have Do you want the standard to become bigger than just Ethereum or just futureproofing? My main principle remains the same: Simplicity = wider adoption.Let's see what other developers working on implementing the standard will tell, what is their feedback. For the time being, I will focus on finishing the hackathon project. (money well spent, incentivizing people to look at the standard) FYI: While working on the hackathon and evaluating the standard I’ve created something simple: https://genesis.re/kleros-metaevidence-metahash/ “Making uploading to IPFS easier since 2019” EDIT: http://jonathanpatrick.me/blog/ethereum-compressed-text
Do you think it will be possible to have completely on-chain arbitrator? On-chain cannot read |
I understand what you are saying, but for a standard it is more important that it is future proof than being simple/easy to adopt. That being said if there are ways to simplify the standard without compromising functionality than I am all for it. Adoption is important, but it is more important that the standard can work for as many use cases as possible or else it will quickly reach it's limits and won't be a useful standard. You can always use a simplified version of the standard JSON if you do not need all of the different fields.
IPFS uses multihash. Multihash is used because it allows different hash functions to co-exist. Actually Ethereum hashing standards are confusing already. Solidity uses a non-standard implementation of
What would be the purpose of an on-chain arbitrator? You always need some end user to give the ruling, regardless of whether they are reading the dispute information from the contract state or the event logs. All of the advantages that are in the passage you quoted are true here and I don't see any advantages to using storage in this use case. The contract itself cannot make a ruling so it has no need to access the Evidence or MetaEvidence. |
About IPFS and multihash: https://github.com/ipfs/specs/tree/master/architecture#21-multihash-and-upgradeable-hashing (didn't know about it) MetaEvidence, MetaHash, it all sounds so meta. I agree that most likely there is no need for on-chain arbitrator. If AI gets sophisticated enough, I'll build their own toolchain to read Events or use the Archon library. EDIT: Still confused. We managed to agree that events are accessed off-chain. How on-chain code can know the identifier of the event? Copy paste from the previous comments:
|
It is referring to And yes the more eyes we get on this the better! |
RELATED: Have you heard of https://opentimestamps.org/ https://en.wikipedia.org/wiki/OpenTimestamps ? Committing to a value, ensuring that piece of evidence existing before a certain time. What are your thoughts about going IPFS only? This ERC1497 is specific to Ethereum (emitting events for example) and I'm leaning towards establishing IPFS as standard. (dropping support for traditional servers) Rationale: no need to store hash, as the filename is the hash. Audience technical enough to handle the standard will be able to handle IPFS with breeze. Shameless plug - https://genesis.re/kleros-metaevidence-metahash/ - making it easier 😇 |
🚗 💨 some drive-by comments from IPFS :) On IPFS Addressing
Linked issue is super old (2015), we will close it to decrease noise (sorry!). That being said, in contexts that do not require strict URI/URL interop, things can be simplified:
On CIDs and Multihashes
fyi IPFS wraps raw Multihash in Content IDentifier (CID) these days:
tl;dr: If you want your spec to be better aligned with IPFS concepts, it should be worded around CIDs, not raw Multihashes. Referring to content via raw multihash is fine and will still work, but you may consider some benefits of custom base and knowing content type before it is fetched. Example: CIDv1 encoded in Base32 can be used in authority part of URLs: Refs.
|
Hi @lidel. Thanks for the clarifications and suggestions. For the purposes of this standard it is not necessary to spell out the accepted CIDs are an interesting idea. We could then remove |
Cool, just wanted to put the concept of a CID on the radar in case its useful for this or future standards. Going with raw multihash should be fine if you don't care about CID, or as long you also store DAG type or all data is in the same DAG format. For example, CIDv1 of IPFS files can be derived from multihash alone, if needed. |
There are 2 typos in the metaEvidence json:
|
Follow-on ProposalWe are making some additions to this proposal in a backwards-compatible fashion. MotivationAlmost 3 years have passed since this proposal was created and we learned a lot about what it takes to build applications on both the Arbitrator and the Arbitrable side. As it currently is, the standard leaves a lot of unanswered questions that could lead to issues down the road. To alleviate this problem, we are adding some fields and recommended ways of solving common problems when building arbitrable and arbitrator applications. SpecificationMetaEvidenceExample: {
"type": "single-select",
"titles": ["Yes", "No"],
"descriptions": [
"The website is compliant. This will release the funds to Alice.",
"The website is not compliant. This will refund Bob."
],
"arbitratorChainID": 1,
"arbitrableChainID": 100,
"arbitrableInterfaceURI": "https://my-awesomme.dapp.io/item/1234",
"dynamicScriptRequiredParams": [
"arbitrableChainID",
"arbitrableJsonRpcUrl"
"arbitrableContractAddress",
],
"evidenceDisplayInterfaceRequiredParams": [
"disputeID",
"arbitrableContractAddress",
"arbitratorContractAddress",
"arbitratorChainID",
"arbitratorJsonRpcUrl"
],
"_v": "1.0.0"
}
_v
{
// ...
"_v": string,
} Identifies which version of the standard the files refer to. This enables interfaces and consumers to support multiple versions at the same time. The changes made in this follow-on document constitute the Whenever arbitrableChainID{
// ...
"arbitrableChainID": number,
} The ID of the chain (as defined by EIP-155) in which the arbitrable application is running. If omitted, the Arbitrable side SHOULD implicitly be considered to be on the same chain as the Arbitrator. arbitratorChainID{
// ...
"arbitratorChainID": number,
} The ID of the chain (as defined by EIP-155) in which the arbitrator for the arbitrable application is running. When present, the Arbitrator interface MUST validate whether it is currently connected to the same chain ID or not. If there is a mismatch, the interface SHOULD consider the If omitted, the Arbitrable side can implicitly be connected to arbitrators on any chain. arbitrableInterfaceURI{
// ...
"arbitrableInterfaceURI": string,
} An URI pointing directly to the arbitrable item on the arbitrable application to make it easier for jurors to view the full context of what originated the dispute. dynamicScriptRequiredParams{
// ...
"dynamicScriptRequiredParams": string[],
} The name of the parameters that are required to be injected into the script defined in When provided, only the required parameters SHOULD be injected. If omitted, all parameters MUST be injected. evidenceDisplayInterfaceRequiredParams{
// ...
"evidenceDisplayInterfaceRequiredParams": string[],
} The name of the parameters that are required to be injected into the interface defined in When provided, only the required parameters SHOULD be injected. If omitted, all parameters MUST be injected. Injected ParametersThe script defined by
Injecting parameters into dynamic scriptsFrom the original spec:
Arbitrator interfaces MUST include a read-only global variable named
Injecting parameters into evidence display interfacesFrom the original spec:
Modern browsers already take care of most of the aspects pointed above. For example, a script from a page within an The Arbitrator interface SHOULD inject the parameters into the Evidence Display Interface using standardized methods available. The most straightforward way of doing this is by appending a search part to Supposing the
To avoid issues with the encoding of the parameters, the Arbitrator interface SHOULD use proper APIs to generate the search part of the URL, such as Common PitfallsHard-coded JSON RPC endpointsDynamic Scripts and Evidence Display Interfaces are meant to be immutable. If they include hard-coded parameters, such as the chain ID or the JSON RPC endpoint URL, it means that those cannot be patched in the future. One clear example on how this falls short is when using RPC endpoints from Infura. They include an Infura project ID in them in order to identify the account responsible for it. Having an Infura endpoint is hard-coded into a dynamic script or an evidence display interface brings the following problems:
Problem 2. above has further consequences:
For that reason, neither dynamic script nor evidence display interfaces should rely on hard-coded parameters in order to connect to the blockchain. Cross-chain/cross-rollup
|
DateTime Ruling Option TypeIntroducing a new type Example: Ruling code 1632930595 translates to Wed Sep 29 2021 15:49:55 GMT+0000. Reserved RulingsTo let arbitrable applications create reserved ruling options, we are introducing a new field Example:
Note that ruling code zero was always reserved for 'Invalid / Refuse to Arbitrate' implicitly, and it will stay that way. For sake of being explicit, you can include it inside metaevidence. User interfaces will ignore definitions for '0x0' anyway. Reserved ruling options take precedence of regular ruling options. So for example, in a Example:
'My Special Ruling Option' will override 'Perhaps' in the above configuration. |
There has been no activity on this issue for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
This issue was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment. |
Why add that parameter then? Shouldn't be the display interface's responsibility to connect to a JSON-RPC endpoint? It knows the chainId. |
Maybe ENS is, at this point, a better standard for this, and this doesn't need to be addressed in the MetaEvidence. |
If I was rate this EIP:
Candid feedback on Kleros |
Yes I agree some attributes are not easy to understand for people who are not in the Kleros space. But (most of) the attributes are optional. So I think we need to clarify the basic attributes versus advanced attributes. |
How do we ensure, whether it's for MetaEvidence or Evidence, that the evidence hasn't been altered if a (multi)hash isn't present in the URI i.e |
FYI I posted on Kleros forum with a proposal to simplify the evidence standard: https://forum.kleros.io/t/the-simplest-evidence-standard-superseding-eip1497/954 I find this particular GitHub issue dated (most of the discussion from 2018 and 2019) but I'm not religious about it, as long as everyone is one the same page. RANDOM RANT I think I've just wasted 1 hour figuring things out, caching |
Abstract
The following describes the standards for
MetaEvidence
andEvidence
for dispute resolution.Evidence
is provided by a participant in a dispute in order to support their assertion.MetaEvidence
gives context to the dispute so that arbitrators are able to accurately and fairly evaluate it. This standard follows ERC 792 and referencesArbitrator
andArbitrable
contracts.Motivation
Standardizing
MetaEvidence
andEvidence
allows interoperability betweenArbitrable
DApps (DApps where disputes can arise) andArbitrator
DApps (DApps which can be used to resolve disputes). It allows these applications to easily switch from one arbitration service to another, or to let their users decide which arbitration service to use without having to spend time to integrate with all of them.MetaEvidence
is required to provide the context of the dispute.Evidence
allows for dispute participants to submit extra information for the arbitrators.The ERC792 standardizes the way the smart contracts interact with each other while this standard is made to standardize the way the interfaces interact in the context of disputes.
Specification
MetaEvidence
MetaEvidence
provides the context of the dispute, the question the arbitrators have to answer, the human readable meanings of rulings and specific modes of display for evidence.NOTE: Each dispute includes only one piece of
MetaEvidence
, however, the sameMetaEvidence
can be used for multiple disputes.NOTE: It is up to the
Arbitrable
contract to determine howMetaEvidence
is submitted and assigned to a dispute.NOTE: In some use cases,
MetaEvidence
is all that theArbitrator
will need in order to make a ruling.NOTE: All
MetaEvidence
fields are optional. AnArbitrator
interface should have defaults for every field. However, not supplying contextual fields may affect the arbitrator’s ability to make an accurate ruling. Not supplying hash fields meant to secure the integrity of the data may result in arbitrators being warned that the data could have been altered.Events
MetaEvidence
MetaEvidence
has to be created before a dispute can arise. TheMetaEvidence
event includes an identifier used to link theMetaEvidence
to a dispute and the_evidence
reference is a URI to a JSON file, specified below, whose name is the multihash hash of the file with no file type extension. The JSON file should have all insignificant whitespace removed before hashing.To be emitted when
MetaEvidence
is submitted:JSON
The
MetaEvidence
JSON file includes the following properties:fileURI
The URI that leads to a natural language contract, agreement, or primary document that is the basis of the dispute. The file name should be the multihash hash of the resulting file. If this is not possible use
fileHash
.Example: "/ipfs/QmUQMJbfiQYX7k6SWt8xMpR7g4vwtAYY1BTeJ8UY8JWRs9”
fileHash
The multihash hash of the primary document file. This may not be included for dynamic or mutable evidence. Not including the hash, either as the file name or in this property, may result in arbitrators being made aware that the evidence could have been altered.
Example: “QmUQMJbfiQYX7k6SWt8xMpR7g4vwtAYY1BTeJ8UY8JWRs9”
fileTypeExtension
The file type extension of the resulting file. This can be used by an
Arbitrator
interface to display the file.Example: “pdf”
category
A short (one word or phrase) high level identifier for the type of dispute. E.g. “Curated List”, “Oracle” or “Escrow”.
Example: "Escrow"
title
Title that summarizes the relationship between the participants.
Example: "Alice Builds a Webpage for Bob"
description
Description of the relationship between the participants. Here is where more detail can be provided so that arbitrators can fully understand the context in which the dispute arose. It can be a summary of the terms of the primary document file, and/or include other contextual information.
Example: "Alice is hired by Bob as a contractor to create a website for his company. When completed, the site will be hosted at https://my-site.com."
aliases
A mapping that can be used by the
Arbitrator
interface to translate each given key to the supplied value. For example, ETH addresses can be mapped to human readable terms to make the dispute easier to understand.Example:
question
The question that arbitrators have to answer.
Example: "Is the website compliant with the terms of the contract?"
rulingOptions
Information about the ruling options to provide clarity on the available rulings to arbitrators.
Indexes of
titles
anddescriptions
map to the ruling options of theArbitrable
contract. Ruling indexing starts at ruling option 1 (rulingOptions.titles[0] corresponds to ruling option 1 in theArbitrable
contract). The ruling option 0 is always reserved for “Refuse to Arbitrate” and should not be included in the array. TheArbitrator
interface can specify the specific title and description used for the “Refuse to Arbitrate” ruling.type
is used to indicate to the arbitrator interface how a ruling should be made. There are 5 basic types that an arbitrator interface are expected to support. If atype
is not specified, the arbitrator interface should default to typesingle-select
. Arbitrator interfaces can choose to support other custom types.single-select
: arbitrators select one answer among the provided options.multiple-select
: arbitrators can select any number of the provided options.uint
: arbitrators input an unsigned integer.int
: arbitrators input a signed integer.string
: arbitrators enter a string. String must fit intobytes32
.precision
is used for ruling typesint
anduint
to indicate the number of decimal places a ruling contains.Example:
evidenceDisplayInterfaceURI
The URI to a display interface that should be used to render the evidence for arbitrators. The
Arbitrator
interface should use an iframe to render the display interface. Data can be passed to the custom display interface with query parameters or with browser based approaches such aswindow.postMessage
.NOTE:
Arbitrator
interfaces should still have a default way to display evidence, as not all evidence will use a custom evidence display interface.NOTE:
Arbitrator
interfaces should take security precautions when injecting the evidence display interface code into their page. The iframe used to render the external interface should be secured properly with a sandbox or other means of disabling functionality that could pose a security risk to the interface or users. For example, an interface should disallow the injectedweb3
object from MetaMask or a different browser wallet from requesting signatures from the user. This can be accomplished by using a sandbox to disallow the external interface from retaining its origin (and therefore using the browser’s built in security features to block API requests), or by removing methods such assign
andpersonalSign
from the injectedweb3
object.Example: "https://my-site.com/evidence-display/escrow"
evidenceDisplayInterfaceHash
Like
fileHash
forfileURI
.Example: “QmUQMJbfiQYX7k6SWt8xMpR7g4vwtAYY1BTeJ8UY8JWRs9”
dynamicScriptURI
The URI of a script that can be run when the
MetaEvidence
is fetched by an arbitrator interface in order to make dynamic updates. The script should expose a functiongetMetaEvidence
that returns JSON, which should be merged with the originalMetaEvidence
JSON.NOTE:
Arbitrator
interfaces should take security precautions when running an external script. A script should never be run directly inline as this would give the script full access to the DOM and make calls on behalf of the arbitrator. Instead the script should be run in a sandbox such as an iframe so that the scope is limited.Example: "/ipfs/QmUQMJbfiQYX7k6SWt8xMpR7g4vwtAYY1BTeJ8UY8JWRs9”
dynamicScriptHash
Like
fileHash
forfileURI
.Evidence
Arbitrable
contracts emit an event that contains a reference to an evidence JSON file when new evidence is submitted.Events
Evidence
The event log should include the
Arbitrator
contract, an identifier for theEvidenceGroup
it belongs to, the address of the submitting party, and reference to the evidence itself. The evidence reference is a URI to a JSON file, specified below, whose name is the multihash hash of the file with no file type extension. The JSON file should have all insignificant whitespace removed before hashing.NOTE: An
EvidenceGroup
is used to link individual pieces of evidence and eventually to link the entire grouping of evidence to a dispute. An Evidence Group must have it's own unique identifier so that Evidence can be submitted before a dispute has been raised.To be triggered when evidence is submitted:
JSON
The
Evidence
JSON file includes the following properties:fileURI
Like the
fileURI
forMetaEvidence
.Example: “/ipfs/QmWQV5ZFFhEJiW8Lm7ay2zLxC2XS4wx1b2W7FfdrLMyQQc”.
fileHash
Like the
fileHash
forMetaEvidence
.Example: “QmWQV5ZFFhEJiW8Lm7ay2zLxC2XS4wx1b2W7FfdrLMyQQc”.
fileTypeExtension
Like the
fileTypeExtension
forMetaEvidence
.Example: “pdf”.
name
What the piece of evidence should be called.
Example: “Email clarifying the terms of the contract.”
description
A brief description of what the evidence contains. Can also include any necessary context to understand the evidence.
Example: “This is an email sent to Alice from Bob that clarifies that the checkout screen can be integrated with the catalog page.”
Dispute
A dispute must include a
MetaEvidence
and anEvidenceGroup
. A dispute can have oneMetaEvidence
and many pieces ofEvidence
that are linked together by anEvidenceGroup
.Events
Dispute
The
Dispute
event is raised when a dispute is created to link the properMetaEvidence
andEvidenceGroup
to the dispute. The event includes a reference to theArbitrator
, a unique identifier for the dispute itself, the identifier used to look up theMetaEvidence
event log and the identifier of theEvidenceGroup
that can be used to look up all evidence submitted in the grouping.To be emitted when a dispute is created.
Rationale
MetaEvidence
orEvidence
file. Hashes included in the JSON file of theMetaEvidence
orEvidence
can then be used to verify that the evidence has not changed since submission.MetaEvidence
andEvidence
JSON to maximize flexibility on the types of links that can be used (as opposed to only supporting the hash as the file name). For example, if the evidence is a news article or some other public resource, the hash needs to be included separately.dynamicScriptURI
was chosen instead of a callback because it gives Arbitrable parties the ability to provide audibility. The script can be publicly posted with the included hash so that arbitrators can verify that the same edits are being made for everyone who runs the script. It is harder to prove this on a privately hosted callback.Implementations
Smart Contract Examples
Single Dispute
Arbitrable
Contract:https://github.com/kleros/kleros-interaction/blob/master/contracts/standard/arbitration/ArbitrableTransaction.sol
Multi-Dispute
Arbitrable
Contract:https://github.com/kleros/kleros-interaction/blob/master/contracts/standard/arbitration/MultipleArbitrableTransaction.sol
JSON File Examples
https://s3.us-east-2.amazonaws.com/kleros-examples/9fgZ2uU5hUtmhNZX4h64LSAAGP5VBCsVeLVSCyyESxN9121wuRs9vaV1Y3Pn9P1XKoX5unszjc16bz6WCMoFdKP1ow
Evidence Display Interface Examples
Arbitrator
Interface Code:https://github.com/kleros/kleros-juror-front/blob/3ecafbbddd036779993c2bca2ace40882ebe164a/src/containers/dispute/components/details/index.js
Dynamic Script Examples
The text was updated successfully, but these errors were encountered: