Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links from EIPs to ERCs cause eipw to fail #8689

Open
SamWilsn opened this issue Jun 25, 2024 · 5 comments
Open

Links from EIPs to ERCs cause eipw to fail #8689

SamWilsn opened this issue Jun 25, 2024 · 5 comments
Labels
bug If this is a PR, this PR fixes a bug. If this is an issue, this issue reports a bug.

Comments

@SamWilsn
Copy link
Contributor

Pull Request

https://github.com/ethereum/EIPs/pull/8594/files

What happened?

When you link from an EIP to an ERC using the correct syntax, the markdown-link-status lint errors out. This is incorrect.

Relevant log output

2024-06-17T02:18:49.9597214Z ##[error]error[markdown-link-status]: unable to read file `eip-7683.md`: Io: JsValue(Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
    at async open (node:internal/fs/promises:636:25)
    at async readFile (node:internal/fs/promises:1246:14))
  --> EIPS/eip-7713.md
   |
26 | A recent example is found in [ERC-7683](./eip-7683.md), which defines a struct with the following member:
   |
   = help: see https://ethereum.github.io/eipw/markdown-link-status/
2024-06-17T02:18:49.9625536Z ##[error]error[markdown-refs]: unable to read file `eip-7683.md`: Io: JsValue(Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
    at async open (node:internal/fs/promises:636:25)
    at async readFile (node:internal/fs/promises:1246:14))
  --> EIPS/eip-7713.md
   |
26 | A recent example is found in [ERC-7683](./eip-7683.md), which defines a struct with the following member:
   |
   = help: see https://ethereum.github.io/eipw/markdown-refs/
2024-06-17T02:18:49.9634594Z ##[error]validation found errors :(
@SamWilsn SamWilsn added the bug If this is a PR, this PR fixes a bug. If this is an issue, this issue reports a bug. label Jun 25, 2024
@SamWilsn SamWilsn mentioned this issue Jun 25, 2024
Merged
@github-actions GitHub Actions
Copy link

There has been no activity on this issue for 1 week. It will be closed after 3 months of inactivity.

@github-actions github-actions bot added the w-stale Waiting on activity label Aug 22, 2024
@Mortiemi
Copy link

Mortiemi commented Sep 3, 2024

Żądanie ściągnięcia

https://github.com/ethereum/EIPs/pull/8594/files

Co się stało?

When you link from an EIP to an ERC using the correct syntax, the markdown-link-status lint errors out. This is incorrect.

Odpowiednie wyjście dziennika

2024-06-17T02:18:49.9597214Z ##[error]error[markdown-link-status]: unable to read file `eip-7683.md`: Io: JsValue(Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
    at async open (node:internal/fs/promises:636:25)
    at async readFile (node:internal/fs/promises:1246:14))
  --> EIPS/eip-7713.md
   |
26 | A recent example is found in [ERC-7683](./eip-7683.md), which defines a struct with the following member:
   |
   = help: see https://ethereum.github.io/eipw/markdown-link-status/
2024-06-17T02:18:49.9625536Z ##[error]error[markdown-refs]: unable to read file `eip-7683.md`: Io: JsValue(Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
    at async open (node:internal/fs/promises:636:25)
    at async readFile (node:internal/fs/promises:1246:14))
  --> EIPS/eip-7713.md
   |
26 | A recent example is found in [ERC-7683](./eip-7683.md), which defines a struct with the following member:
   |
   = help: see https://ethereum.github.io/eipw/markdown-refs/
2024-06-17T02:18:49.9634594Z ##[error]validation found errors :(

@github-actions github-actions bot removed the w-stale Waiting on activity label Sep 4, 2024
@GIgako19929
Copy link

https://github.com/ethereum/EIPs/issues/8689~~```

@rutefig
Copy link

rutefig commented Sep 18, 2024

Hey @SamWilsn can I have this one pls?

@grattitude
Copy link

Pull Request

https://github.com/ethereum/EIPs/pull/8594/files

What happened?

When you link from an EIP to an ERC using the correct syntax, the markdown-link-status lint errors out. This is incorrect.

Relevant log output

2024-06-17T02:18:49.9597214Z ##[error]error[markdown-link-status]: unable to read file `eip-7683.md`: Io: JsValue(Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
    at async open (node:internal/fs/promises:636:25)
    at async readFile (node:internal/fs/promises:1246:14))
  --> EIPS/eip-7713.md
   |
26 | A recent example is found in [ERC-7683](./eip-7683.md), which defines a struct with the following member:
   |
   = help: see https://ethereum.github.io/eipw/markdown-link-status/
2024-06-17T02:18:49.9625536Z ##[error]error[markdown-refs]: unable to read file `eip-7683.md`: Io: JsValue(Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
Error: ENOENT: no such file or directory, open 'EIPS/eip-7683.md'
    at async open (node:internal/fs/promises:636:25)
    at async readFile (node:internal/fs/promises:1246:14))
  --> EIPS/eip-7713.md
   |
26 | A recent example is found in [ERC-7683](./eip-7683.md), which defines a struct with the following member:
   |
   = help: see https://ethereum.github.io/eipw/markdown-refs/
2024-06-17T02:18:49.9634594Z ##[error]validation found errors :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug If this is a PR, this PR fixes a bug. If this is an issue, this issue reports a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@rutefig @SamWilsn @Mortiemi @GIgako19929 @grattitude and others