-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-7642: don't remove NewBlock(Hashes) #9133
Conversation
✅ All reviewers have approved. |
|
||
- Removing the `NewBlock` message. | ||
Additionally we propose to remove the field that was deprecated by the merge, namely | ||
the `TD` field in the `Status` message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could make consistent with capitalisation of td
/ TD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I simply kept the original capitalization.
Is it important to maintain compatibility with other chains here? Couldn't they update to match mainnet? |
It's a balancing act between moving Ethereum mainnet forward and maintaining compatibility with the broader ecosystem. The proposed removal brings little or none benefit to mainnet, while causing an incompatibility with other blockchains, that are closely aligned but not identical to mainnet. That one of the points of L2s – to be aligned with Ethereum, but still leave room for differences and innovation. |
This PR was discussed (inlc. with @fjl) on the ACDE on 19 Dec and approved. @MariusVanDerWijden could you approve and merge it please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM, I have not checked the acd recording, will take your word for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
If
NewBlock
andNewBlockHashes
are removed from the protocol, it makes it incompatible with other blockchains that haven't gone through The Merge, such as Polygon. For Ethereum, formally removingNewBlock
(Hashes
) is unnecessary since those are not sent anyway after The Merge (as stipulated by EIP-3675).