Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-7642: don't remove NewBlock(Hashes) #9133

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

yperbasis
Copy link
Member

If NewBlock and NewBlockHashes are removed from the protocol, it makes it incompatible with other blockchains that haven't gone through The Merge, such as Polygon. For Ethereum, formally removing NewBlock(Hashes) is unnecessary since those are not sent anyway after The Merge (as stipulated by EIP-3675).

@yperbasis yperbasis requested a review from eth-bot as a code owner December 13, 2024 16:48
@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-networking labels Dec 13, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Dec 13, 2024

✅ All reviewers have approved.


- Removing the `NewBlock` message.
Additionally we propose to remove the field that was deprecated by the merge, namely
the `TD` field in the `Status` message.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could make consistent with capitalisation of td / TD

Copy link
Member Author

@yperbasis yperbasis Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I simply kept the original capitalization.

@Marchhill
Copy link
Contributor

Is it important to maintain compatibility with other chains here? Couldn't they update to match mainnet?

@yperbasis
Copy link
Member Author

Is it important to maintain compatibility with other chains here? Couldn't they update to match mainnet?

It's a balancing act between moving Ethereum mainnet forward and maintaining compatibility with the broader ecosystem. The proposed removal brings little or none benefit to mainnet, while causing an incompatibility with other blockchains, that are closely aligned but not identical to mainnet. That one of the points of L2s – to be aligned with Ethereum, but still leave room for differences and innovation.

@yperbasis
Copy link
Member Author

This PR was discussed (inlc. with @fjl) on the ACDE on 19 Dec and approved. @MariusVanDerWijden could you approve and merge it please?

Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, I have not checked the acd recording, will take your word for it

@eth-bot eth-bot enabled auto-merge (squash) December 20, 2024 14:55
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit ff40bfe into ethereum:master Dec 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-draft This EIP is a Draft t-networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants