-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-223: Remove standard
function
#7856
Conversation
File
|
standard
functionstandard
function
I would support this changes but the removal of this function now would require the update of the reference implementation code as well since the function is also presented there. I'm also working on a Token Standard Converter as according to EIP-7417 (btw that would help if you could merge the EIP-7417 PR, I'm waiting for it for 3 weeks without any response) The Even though the "standard recognition" can be reinstated as a separate informational EIP here is the question - is it worth the effort to remove it from a final EIP and reference code just to make it a separate EIP? |
Actually, it's perfectly fine for you to keep the standard function there! If you'd like it removed, however, I'd be happy to comply.
Sorry about the wait. I'll look into it!
The interface ID is the XOR of all the function selectors, so they should be different. https://eips.ethereum.org/EIPS/eip-5269 and https://eips.ethereum.org/EIPS/eip-1046 might also interest you, although the latter applies less directly to your token converter EIP.
Considering most if not all of the work would be done by editors, I'd say yes, this is worth it. Take a look at ERC-165 and/or ERC-5269 and let me know what you think! ERC-5269 is still in Review, so if you have any strong feelings, @xinbenlv will probably be able to collaborate with you to refine them! |
I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually. As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process. If there is relevant history here, please link to this PR from the new pull request. On behalf of the EIP Editors, I apologize for this inconvenience. |
ERC-223 needs an errata:
standard
function was out-of-scope and insisted that it be removedRemoving this function is a backward compatible change, as applications cannot expect it to be present.