From 55b6c29d5129737585080c1ed5031be25ea8131d Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 09:01:47 +0200 Subject: [PATCH 01/13] login github test --- .circleci/config.yml | 2 +- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index afe5c5576bb..55755e31e6c 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -3,7 +3,7 @@ version: 2.1 parameters: run_flaky_tests: type: boolean - default: false + default: true orbs: browser-tools: circleci/browser-tools@1.4.4 win: circleci/windows@5.0 diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index daa7d17baa0..0945da1c362 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -25,7 +25,7 @@ module.exports = { .waitForElementVisible('*[data-id="filepanel-login-github"]') .click('*[data-id="filepanel-login-github"]') }, - 'login to github #group1 #group2': function (browser: NightwatchBrowser) { + 'login to github #flaky #group1 #group2': function (browser: NightwatchBrowser) { browser .waitForElementVisible('*[data-id="github-panel"]') .waitForElementVisible('*[data-id="gitubUsername"]') From 51c115e6dd1987aaea23f27a925125872bb26ff3 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 09:18:58 +0200 Subject: [PATCH 02/13] group1 --- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index 0945da1c362..d7c793ff856 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -25,7 +25,7 @@ module.exports = { .waitForElementVisible('*[data-id="filepanel-login-github"]') .click('*[data-id="filepanel-login-github"]') }, - 'login to github #flaky #group1 #group2': function (browser: NightwatchBrowser) { + 'login to github #group1 #group2': function (browser: NightwatchBrowser) { browser .waitForElementVisible('*[data-id="github-panel"]') .waitForElementVisible('*[data-id="gitubUsername"]') @@ -45,7 +45,7 @@ module.exports = { .clickLaunchIcon('filePanel') .waitForElementVisible('*[data-id="filepanel-connected-img-bunsenstraat"]') }, - 'clone a repository #group1': function (browser: NightwatchBrowser) { + 'clone a repository #flaky #group1': function (browser: NightwatchBrowser) { browser .clickLaunchIcon('dgit') .click('*[data-id="clone-panel"]') From d7ab9a83ae65cb59e309d87857cae19116c9b243 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 09:32:35 +0200 Subject: [PATCH 03/13] add pause --- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index d7c793ff856..b18938fd086 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -22,6 +22,7 @@ module.exports = { 'launch github login via FE #group1 #group2': function (browser: NightwatchBrowser) { browser .clickLaunchIcon('filePanel') + .pause(1000) .waitForElementVisible('*[data-id="filepanel-login-github"]') .click('*[data-id="filepanel-login-github"]') }, From b8bd045e4e828590ba869ba2e10ebcaa62956d7a Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 09:40:34 +0200 Subject: [PATCH 04/13] add pause --- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index b18938fd086..c264fee0edb 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -213,6 +213,7 @@ module.exports = { .waitForElementVisible('*[data-id="github-panel"]') .click('*[data-id="github-panel"]') .waitForElementVisible('*[data-id="disconnect-github"]') + .pause(1000) .click('*[data-id="disconnect-github"]') .waitForElementNotPresent('*[data-id="connected-as-bunsenstraat"]') }, From e95ab338d3e71516dda51334593a7417f121becc Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 09:48:04 +0200 Subject: [PATCH 05/13] add pauses --- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index c264fee0edb..bb6263091cf 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -31,8 +31,11 @@ module.exports = { .waitForElementVisible('*[data-id="github-panel"]') .waitForElementVisible('*[data-id="gitubUsername"]') .setValue('*[data-id="githubToken"]', process.env.dgit_token) + .pause(1000) .setValue('*[data-id="gitubUsername"]', 'git') + .pause(1000) .setValue('*[data-id="githubEmail"]', 'git@example.com') + .pause(1000) .click('*[data-id="saveGitHubCredentials"]') }, 'check if the settings are loaded #group1 #group2': function (browser: NightwatchBrowser) { From d8d6cf258cf25ece3461893a8299300adb1104a7 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 09:58:13 +0200 Subject: [PATCH 06/13] add pause --- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index bb6263091cf..553987faf98 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -121,6 +121,7 @@ module.exports = { .click('*[data-id="remotes-panel"]') .waitForElementVisible('*[data-id="remotes-panel-content"]') + .pause(2000) .waitForElementVisible({ selector: '//*[@data-id="remotes-panel-content"]//*[@data-id="remote-detail-origin-default"]', locateStrategy: 'xpath' From fcdcc2db1568ae167c9045bd7f97a198ddc95c1a Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 10:11:07 +0200 Subject: [PATCH 07/13] group2 --- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index 553987faf98..e4875bb6c68 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -49,7 +49,7 @@ module.exports = { .clickLaunchIcon('filePanel') .waitForElementVisible('*[data-id="filepanel-connected-img-bunsenstraat"]') }, - 'clone a repository #flaky #group1': function (browser: NightwatchBrowser) { + 'clone a repository #group1': function (browser: NightwatchBrowser) { browser .clickLaunchIcon('dgit') .click('*[data-id="clone-panel"]') @@ -227,7 +227,7 @@ module.exports = { .waitForElementNotPresent('*[data-id="filepanel-connected-img-bunsenstraat"]') .waitForElementVisible('*[data-id="filepanel-login-github"]') }, - 'add a remote #group2': function (browser: NightwatchBrowser) { + 'add a remote #flaky #group2': function (browser: NightwatchBrowser) { browser .pause(1000) .clickLaunchIcon('dgit') From c8ae78ba07756cccaa51bbfad9199c2017493231 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 10:20:08 +0200 Subject: [PATCH 08/13] more pause --- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index e4875bb6c68..c83fedc2511 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -290,6 +290,7 @@ module.exports = { selector: "//div[@id='commands-local-branch-select']//div[contains(@class, 'singleValue') and contains(text(), 'main')]", locateStrategy: 'xpath' }) + .pause(1000) .getAttribute({ selector: '//*[@data-id="sourcecontrol-pull"]', locateStrategy: 'xpath' From df3438faea8b59f7c29fa6e7d86640b7918f9ecc Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 10:30:50 +0200 Subject: [PATCH 09/13] pause --- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index c83fedc2511..1da36253c11 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -16,8 +16,10 @@ module.exports = { 'Update settings for git #group1 #group2': function (browser: NightwatchBrowser) { browser. clickLaunchIcon('dgit') + .pause(1000) .waitForElementVisible('*[data-id="initgit-btn"]') .click('*[data-id="initgit-btn"]') + .pause(1000) }, 'launch github login via FE #group1 #group2': function (browser: NightwatchBrowser) { browser From ad271fd4221a382b1d1f8105cb4d66b3946f293c Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 10:31:23 +0200 Subject: [PATCH 10/13] assert --- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index 1da36253c11..69d44f3f3ef 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -19,7 +19,7 @@ module.exports = { .pause(1000) .waitForElementVisible('*[data-id="initgit-btn"]') .click('*[data-id="initgit-btn"]') - .pause(1000) + .waitForElementNotPresent('*[data-id="initgit-btn"]') }, 'launch github login via FE #group1 #group2': function (browser: NightwatchBrowser) { browser From 4e6cb8a6db06d28b6abd58d034223514bfa1c74f Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 10:32:34 +0200 Subject: [PATCH 11/13] assert --- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index 69d44f3f3ef..fed04a74932 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -45,6 +45,7 @@ module.exports = { .waitForElementVisible('*[data-id="connected-as-bunsenstraat"]') .waitForElementVisible('*[data-id="connected-img-bunsenstraat"]') .waitForElementVisible('*[data-id="connected-link-bunsenstraat"]') + .waitForElementVisible('*[data-id="remotes-panel"]') }, 'check the FE for the auth user #group1 #group2': function (browser: NightwatchBrowser) { browser From ef3a74a25681aac86a9747a3e2325e5621198c31 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 10:43:17 +0200 Subject: [PATCH 12/13] group1 --- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index fed04a74932..780b2783bab 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -52,7 +52,7 @@ module.exports = { .clickLaunchIcon('filePanel') .waitForElementVisible('*[data-id="filepanel-connected-img-bunsenstraat"]') }, - 'clone a repository #group1': function (browser: NightwatchBrowser) { + 'clone a repository #flaky #group1': function (browser: NightwatchBrowser) { browser .clickLaunchIcon('dgit') .click('*[data-id="clone-panel"]') From 621b5499dd8c09e0e049495edbb9e5aafb9d35d0 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 11:00:04 +0200 Subject: [PATCH 13/13] turn off flaky --- .circleci/config.yml | 2 +- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 55755e31e6c..afe5c5576bb 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -3,7 +3,7 @@ version: 2.1 parameters: run_flaky_tests: type: boolean - default: true + default: false orbs: browser-tools: circleci/browser-tools@1.4.4 win: circleci/windows@5.0 diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index 780b2783bab..22bece47275 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -52,7 +52,7 @@ module.exports = { .clickLaunchIcon('filePanel') .waitForElementVisible('*[data-id="filepanel-connected-img-bunsenstraat"]') }, - 'clone a repository #flaky #group1': function (browser: NightwatchBrowser) { + 'clone a repository #group1': function (browser: NightwatchBrowser) { browser .clickLaunchIcon('dgit') .click('*[data-id="clone-panel"]') @@ -230,7 +230,7 @@ module.exports = { .waitForElementNotPresent('*[data-id="filepanel-connected-img-bunsenstraat"]') .waitForElementVisible('*[data-id="filepanel-login-github"]') }, - 'add a remote #flaky #group2': function (browser: NightwatchBrowser) { + 'add a remote #group2': function (browser: NightwatchBrowser) { browser .pause(1000) .clickLaunchIcon('dgit')