Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add partner plugin #5158

Merged
merged 7 commits into from
Sep 16, 2024
Merged

Add partner plugin #5158

merged 7 commits into from
Sep 16, 2024

Conversation

yann300
Copy link
Contributor

@yann300 yann300 commented Sep 2, 2024 •
edited
Loading

  • skip some check for plugins developped by partners.
  • update label template selectioni plugin

@yann300 yann300 added the ready-to-review PR ready to review label Sep 2, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 2, 2024 •
edited
Loading

✅ Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 6dc4c20
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/66e833bbcfa2a60008b27b05
😎 Deploy Preview https://deploy-preview-5158--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Aniket-Engg
Aniket-Engg reviewed Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-09-10 at 7 41 01 PM

Workspace name should be shortened.

Clicking on Explore more templates from cookbook does nothing for me

Trying to use Workspace filter breaks IDE

@Aniket-Engg
Copy link
Collaborator

It seems filter is broken on master too

@yann300 yann300 force-pushed the partner_plugin branch 2 times, most recently from 073291a to bc6f3a9 Compare September 16, 2024 12:56
@Aniket-Engg Aniket-Engg merged commit 28b25d0 into master Sep 16, 2024
32 checks passed
@Aniket-Engg Aniket-Engg deleted the partner_plugin branch September 16, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aniket-Engg Aniket-Engg Aniket-Engg left review comments

@LianaHus LianaHus LianaHus approved these changes

@ryestew ryestew Awaiting requested review from ryestew

Assignees
No one assigned
Labels
ready-to-review PR ready to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yann300 @Aniket-Engg @LianaHus