Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check why the match type changed in #1705 #1714

Closed
kuzdogan opened this issue Oct 24, 2024 · 1 comment
Closed

Check why the match type changed in #1705 #1714

kuzdogan opened this issue Oct 24, 2024 · 1 comment
Assignees
@kuzdogan

Comments

@kuzdogan
Copy link
Member

kuzdogan commented Oct 24, 2024 •
edited
Loading

#1705
@kuzdogan kuzdogan converted this from a draft issue Oct 24, 2024
@kuzdogan kuzdogan changed the title Check why the match type changed in #1507 Check why the match type changed in #1705 Oct 24, 2024
@kuzdogan
Copy link
Member Author

The chain #2442 Polygon zkEVM Cardona Testnet was added with the following commit: a38d61c

Following that being added to staging, the Etherscan test in question has always failed expecting the standard-json type to be perfect but the verification yielded partial. Even starting with the very first run: https://app.circleci.com/pipelines/github/ethereum/sourcify/7103/workflows/694fa6f8-e219-4166-acb2-abf4bbedba2c/jobs/43054

So I am assuming this contract 0xd5a515CE2dF4C69aA809De5b9318a3D4452D86BE has always been a partial match but it was mistakingly added as "perfect".

@github-project-automation github-project-automation bot moved this from Sprint - Candidates to Sprint - Done in Sourcify Public Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kuzdogan kuzdogan

Labels
None yet
Projects
Sourcify Public
Status: Sprint - Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kuzdogan