Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate: switching the libp2p transport from tcp to quic #70

Open
2 of 4 tasks
istae opened this issue Oct 18, 2023 · 3 comments · May be fixed by ethersphere/bee#4424
Open
2 of 4 tasks

investigate: switching the libp2p transport from tcp to quic #70

istae opened this issue Oct 18, 2023 · 3 comments · May be fixed by ethersphere/bee#4424
Assignees
Labels

Comments

@istae
Copy link
Member

istae commented Oct 18, 2023

Background:
quic transport layer, being based on udp, may bypass certain firewalls of certain countries, plus it brings latency benefits

janos writes

so I would suggest to try it again with one consequence, we have made possible especially to support multiple transports on libp2p as underlay addressing. so it should be checked that this is functioning still correctly in addressbook, handshake, hive, logging and so on. so with quic enabled nodes will have at least two underlay addresses that can be advertized and nodes in the network will advertize the underlay that they have connected to two different nodes can send two different underlay addresses for the same node if one connect with tcp and another with quic. also, quic should work faster as it takes over the multiplexing from libp2p

It's been suggested that running both tcp and quic may be a requirement.

Testing will be in 3 steps.

  • Testing on a private cluster (private testnet)
  • Testing on a private cluster with half the node running TCP and other half running TCP and QUIC. Bootnodes MUST advertise both transports.
  • Deploy and test in a new network with nodes running in china and in eu.
  • Test on public testnet.
@bee-runner bee-runner bot added the issue label Oct 18, 2023
@mrekucci mrekucci self-assigned this Oct 23, 2023
@mrekucci mrekucci linked a pull request Oct 25, 2023 that will close this issue
4 tasks
@istae
Copy link
Member Author

istae commented Oct 25, 2023

quic on by default but can be turned off by flag
and when nodes try to connect, they should try quic first
and fallback on peer's tcp address, if any

@nikipapadatou
Copy link

Before we proceed with testing this in chinese nodes, we are testing in EU. Once we succeed with this, we can move to the next step:
Ask node operators from china to help us with deploying more nodes to see the performance. Also we can consider the trusted operator program partners (TOP) to get benefit from them.

@istae istae self-assigned this Nov 1, 2023
@nikipapadatou
Copy link

Putting the current on hold, because it seems that the QUIC addition did not bring the expected results.
https://hackmd.io/tLCzlMIuQCORXPfygngqxg?view

@martinconic martinconic self-assigned this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants