isCompressedKey not forwarded to SignCompact – Intentional or Bug?

[gacevicljubisa]

⚠️ Support requests in an issue-format will be closed immediately. For support, go to Swarm's Discord.

Context

• Bee Version: latest

Summary

The isCompressedKey parameter in pkg/crypto/signer.go appears to be unused in SignCompact, which could lead to unexpected behavior.
Is this intentional behaviour?

Expected behavior

The isCompressedKey parameter should influence the btcecdsa.SignCompact call directly to ensure the correct signing format is applied, as the isCompressedKey variable is intended to define the key compression type.

Actual behavior

The isCompressedKey parameter is defined but is not passed to btcecdsa.SignCompact here. Instead, it is set but not used in the signing process, potentially resulting in signing with the wrong format.

Steps to reproduce

• Examine the isCompressedKey variable in the d.sign(hash, true) method, where isCompressedKey is set to true.
• Notice that isCompressedKey is not forwarded to the btcecdsa.SignCompact function here.

Possible solution

Update SignCompact to forward isCompressedKey to btcecdsa.SignCompact, ensuring the function call respects the compressed key setting.