Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bytes endpoint 404 prints Swarmageddon in the logs for a /bytes/<address> #4934

Open
2 tasks
Cafe137 opened this issue Dec 17, 2024 · 0 comments
Open
2 tasks
Labels
needs-triaging new issues that need triaging

Comments

@Cafe137
Copy link

Cafe137 commented Dec 17, 2024

Context

Bee 2.3.1

Summary

Make an obvious 404 bytes request:

GET http://localhost:1633/bytes/00112233445566778899aabbccddeeff00112233445566778899aabbccddeeff

Bee logs:

"time"="2024-12-17 21:41:06.261675" "level"="error" "logger"="node/api/get_bytes_by_address" "msg"="swarmageddon has begun
storage: not found
storage: not found
storage: not found
storage: not found
storage: not found
storage: not found
storage: not found
storage: not found
storage: not found
storage: not found
storage: not found
storage: not found
storage: not found
storage: not found
storage: not found
storage: not found
storage: not found"

Expected behavior

  • storage: not found is not printed over and over
  • I thought we only printed the "Swarmageddon" text for cases when data MUST exist but is not retrievable. Bee should not throw a tantrum for all bytes 404s.

Actual behavior

Please see summary

Steps to reproduce

Please see summary, it is reproducible with any wrong address.

Possible solution

BZZ endpoint handles it without being overly dramatic:

"time"="2024-12-17 21:18:11.283647" "level"="error" "logger"="node/api/get_bzz_by_path" "msg"="address not found or incorrect"
@Cafe137 Cafe137 added the needs-triaging new issues that need triaging label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triaging new issues that need triaging
Projects
None yet
Development

No branches or pull requests

1 participant