Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

Peer shutting down while waiting for transaction: marking cheques as cashed #1634

Open
Eknir opened this issue Aug 2, 2019 · 3 comments · May be fixed by #2124
Open

Peer shutting down while waiting for transaction: marking cheques as cashed #1634

Eknir opened this issue Aug 2, 2019 · 3 comments · May be fixed by #2124
Assignees

Comments

@Eknir
Copy link
Contributor

Eknir commented Aug 2, 2019

It is possible that the node shuts down, while it is waiting for a transaction to be executed.
Perhaps we should keep a list of cheques and mark them as cashed / uncashed.
Then, when the node boots up again, he verifies his uncashed cheques and if, according to his preferences (which is now: always cash a cheque directly), he wants to submit a cheque which is marked as not submitted, he will first look in the blockchain whether this cheque is really not submitted.

@ralph-pichler
Copy link
Member

Issue description should be updated to only refer to cashing.

@Eknir
Copy link
Contributor Author

Eknir commented Feb 6, 2020

@ralph-pichler , what is the status on this PR?

@ralph-pichler
Copy link
Member

While implemented a bit differently, the general idea behind this will be implemented in #2089 (which will probably be split into smaller PRs).

If you want, we can also close this is in favour of #2005.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants