Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configmap for config.toml to configure more reth settings #312

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mariuspod
Copy link

hey, this is just a small PR to be able to specify pruning options and other reth settings via toml file which is populated by creating a ConfigMap if the config key exists on the values.yaml: https://reth.rs/run/config.html

The file /data/config.toml will be then just overwritten with the contents from the values.yaml

Tested with helm template . --debug

@mariuspod mariuspod requested a review from skylenet as a code owner June 11, 2024 17:38
@mariuspod mariuspod marked this pull request as draft June 12, 2024 08:39
@mariuspod mariuspod marked this pull request as draft June 12, 2024 08:39
@mariuspod mariuspod force-pushed the feat/reth_configmap branch from 7a50579 to 1296c79 Compare June 12, 2024 10:01
@mariuspod mariuspod marked this pull request as ready for review June 12, 2024 10:02
@mariuspod
Copy link
Author

also tested on a real cluster now

@skylenet
Copy link
Member

Hey @mariuspod , sorry for the late reply. Can you bump the version in Chart.yaml and then run make docs and commit those changes? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants