-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to latests matomo-org/device-detector version #134
Comments
Exactly, we updated the up to 4.1.0, we need to continue the upgrade to 4.3.1. |
Just FYI @etienne-martin, @jmaitrehenry: In case you want to easily test if an issue is also on the upstream php device-detector, you can use my site here: It should always return the detection results from the latest master branch of https://github.com/matomo-org/device-detector. |
Great, thanks @Findus23 |
I'm having problems with latest FireTV 4k Max detected as a phone, seems the latest version has a fix for it, is this close to release? |
Are you getting the correct result when using this site https://devicedetector.lw1.at ? |
no, I've copied the Amazon Fire TV 4k max user agent from the web app and using an emulator it's detected as a phone here's the commit that fixes this issue which many of our customers are complaining about here's the user agent so you can test (edited, corrected) |
The latest version of matomo works fine with this user-agent:
Found it in their test fixture. I haven't looked at the new regex introduced by matomo-org/device-detector@5d1fa40 to see what could cause yours to fail. Even if we were to update the library with what's currently upstream, the user-agent you provided would still fail so you can report the issue at https://github.com/matomo-org/device-detector/issues if you think there's something wrong with the detection of that user-agent. Once the issue is fixed upstream, we'll be able to pull these changes into the library. No guarantee that this will be done quickly however. |
|
It's would be a great move to update this lib to the latest version of matomo-org/device-detector (v4.3.1).
This should fix issues:
The text was updated successfully, but these errors were encountered: