Skip to content
This repository has been archived by the owner on Aug 30, 2024. It is now read-only.

"python setup.py install" dies, "mock" can't find required version of "setuptools" #376

Closed
lincolnthomas opened this issue Nov 18, 2015 · 4 comments

Comments

@lincolnthomas
Copy link
Member

In the latest code, "python setup.py install" fails with the error:

$ python setup.py install
running install
[ ... ]
Searching for mock
Reading https://pypi.python.org/simple/mock/
Best match: mock 1.3.0
Downloading https://pypi.python.org/packages/source/m/mock/mock-1.3.0.tar.gz#md5=73ee8a4afb3ff4da1b4afa287f39fdeb
Processing mock-1.3.0.tar.gz
Writing /tmp/easy_install-rLfI9X/mock-1.3.0/setup.cfg
Running mock-1.3.0/setup.py -q bdist_egg --dist-dir /tmp/easy_install-rLfI9X/mock-1.3.0/egg-dist-tmp-WDa6fK
mock requires setuptools>=17.1. Aborting installation
error: Setup script exited with 1
@lincolnthomas
Copy link
Member Author

This problem has been seen before, e.g. testing-cabal/mock#316 (comment) , and the workaround was:

pip install --upgrade pip
pip install --force-reinstall mock

However, we believe we really don't need the "mock" package anyway. It's only referenced in tests/Test-eucaops-init.py as an import, and nothing mock-like is ever used.

Therefore, we should be able to remove that import, and remove mock from the setup.py: (diff)

       install_requires = ['paramiko >= 1.7','boto >= 2.5.2', 'jinja2 >= 2.7', 'argparse',
-                          'futures', 'python-dateutil', 'mock', 'dnspython', 'pywinrm',
+                          'futures', 'python-dateutil', 'dnspython', 'pywinrm',
                           'BeautifulSoup', 'requests >= 1', 'prettytable'],

This has shown no adverse effects in my testing so far on my fork https://github.com/lincolnthomas/eutester , but I'm getting an unrelated error I need to resolve before I finish my testing. Work continues.

@lincolnthomas
Copy link
Member Author

New issue #381 has been written for the failure I found during regression testing, which is unrelated to this change.

This issue has been fixed, and no problems were found in concise and full regression tests of all python eutester tests. Making the pull request.

@tbeckham
Copy link
Contributor

tbeckham commented Dec 1, 2015

@shaon or @nephomaniac is this something already taken care of in the eutester rewrite? If not can you review this change?

@lincolnthomas
Copy link
Member Author

Pull request #382 merged upstream, issue closed. Thanks Shaon!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants