Skip to content
This repository has been archived by the owner on Aug 30, 2024. It is now read-only.

Fix test_bucket_location tests #379

Open
lincolnthomas opened this issue Nov 19, 2015 · 2 comments
Open

Fix test_bucket_location tests #379

lincolnthomas opened this issue Nov 19, 2015 · 2 comments

Comments

@lincolnthomas
Copy link
Member

The test_bucket_location() function in testcases/cloud_user/s3/bucket_tests.py fails if pointed to an AWS endpoint.

@lincolnthomas
Copy link
Member Author

Made the test pass, for the default us-east-1 region only. Unfortunately, in AWS, if we create a bucket in another region, we can only delete it if we set up a new connection to that region and then delete it. New connections are outside the scope of these bucket tests.

Changes:

  1. Changed bucket names to DNS-compliance (replacing underscores with periods).
  2. In addition to bucket creation with no location specified, added bucket creation specifying us-east-1 (default location).
  3. Skipped bucket creation in another region if testing against AWS.
  4. Better logging of progress and results.

@lincolnthomas
Copy link
Member Author

Further testing against AWS regions (us-east-1 and eu-west-1 Ireland) uncovered a few more gotchas. Fixed:

  1. Setting bucket versioning and then immediately getting it can sometimes return the old value (failing the test). The versioning status seems to be eventually consistent. Added sleeps of 5 seconds between set and get. Even 2 seconds was not enough.
  2. Erroneous error handling code discovered when EU region tested.
  3. Clarified error messages and comments, and warnings when testing against AWS.

lincolnthomas pushed a commit to lincolnthomas/eutester that referenced this issue Nov 20, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant