Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DockerHub Image? #163

Closed
AndrewQuijano opened this issue Apr 7, 2024 · 5 comments
Closed

DockerHub Image? #163

AndrewQuijano opened this issue Apr 7, 2024 · 5 comments

Comments

@AndrewQuijano
Copy link
Contributor

Hello,
Is there a plan to publish the docker image on DockerHub for easier pulling instead of just installing it? I am open to provide the update to GitHub actions to allow building and pushing the image to DockerHub if you can create a secret with the DockerHub password and what will be the docker hub account name.

@AndrewQuijano
Copy link
Contributor Author

This would be a quick edit to the GitHub Actions

https://github.com/docker/build-push-action

@aurelf
Copy link
Member

aurelf commented Apr 7, 2024

Hi,
sure that's something we had in mind, in particular to simplify SymQEMU tests. Now we are splitting the runtime to a separate repo (PR #162 ), so it's not really a motivation anymore.
That said, making available a Docker image up to date with the main branch is a good idea anyway.
I thought maybe doing a github Package, instead of DockerHub? Maybe this would be better (easier to use here maybe?) although the two options are not exclusive.

@AndrewQuijano
Copy link
Contributor Author

AndrewQuijano commented Apr 7, 2024

I figure more options the better, at least with DockerHub, the workflow is pretty well documented, and I don't mind giving a shot at getting the export going for you, (once the secret is populated), or I can just wait until the PR is complete!

@aurelf
Copy link
Member

aurelf commented Apr 7, 2024

No need to wait for the other PRs, it would be great if you could make a PR, I created the secrets :

          username: ${{ secrets.DOCKER_USERNAME }}
          password: ${{ secrets.DOCKER_PASSWORD }}

this should allow to push images to eurecoms3/symcc on DockerHub.

@AndrewQuijano
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants