Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to reduce copy/paste in SQL code #77

Open
cer opened this issue May 30, 2022 · 0 comments
Open

Refactor to reduce copy/paste in SQL code #77

cer opened this issue May 30, 2022 · 0 comments

Comments

@cer
Copy link
Collaborator

cer commented May 30, 2022

These lines are duplicated in non-reactive repository:

eventuate-tram-sagas/eventuate-tram-sagas-reactive-orchestration/src/main/java/io/eventuate/tram/sagas/reactive/orchestration/ReactiveSagaInstanceRepositoryJdbc.java

Lines 46 to 53 in 536389b

sagaInstance.getSagaType(),
sagaInstance.getId(),
sagaInstance.getStateName(),
sagaInstance.getLastRequestId(),
sagaInstance.getSerializedSagaData().getSagaDataType(),
sagaInstance.getSerializedSagaData().getSagaDataJSON(),
sagaInstance.isEndState(),
sagaInstance.isCompensating())

Consider moving into SagaInstanceRepositorySql and renaming it to ...Mapper.
cer added a commit that referenced this issue Jun 1, 2022
@cer
#75 Handle scenario where compensating transaction returns a failure,…
c4308af 
… Extracted common functionality out of non-reactive and reactive SagaDefinition, #77 Refactor to reduce copy/paste in SQL code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cer