Bump snowflake-sdk to 1.14 #2723

GriffGeorge · 2024-11-04T22:30:15Z

Description

Bump the snowflake-sdk version in order to make #2701 actually work! SSO Caching was introduced in 1.12. This takes us to 1.14 (latest).

Checklist

~~For UI or styling changes, I have added a screenshot or gif showing before & after~~
I have added a changeset
~~I have added to the docs where applicable~~
~~I have added to the VS Code extension where applicable~~

changeset-bot · 2024-11-04T22:30:19Z

🦋 Changeset detected

Latest commit: ae0ca46

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@evidence-dev/snowflake	Patch
e2e-prerender	Patch
e2e-spa	Patch
e2e-themes	Patch
@evidence-dev/components	Patch
evidence-test-environment	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-11-04T22:30:20Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	❌ Failed (Inspect)			Nov 5, 2024 0:58am
next-docs	❌ Failed (Inspect)			Nov 5, 2024 0:58am

netlify · 2024-11-04T22:33:43Z

❌ Deploy Preview for evidence-development-workspace failed. Why did it fail? →

Name	Link
🔨 Latest commit	`dc77eb4`
🔍 Latest deploy log	https://app.netlify.com/sites/evidence-development-workspace/deploys/672a15b79798ed00081cdf43

netlify · 2024-11-04T22:33:43Z

✅ Deploy Preview for next-docs-evidence ready!

Name	Link
🔨 Latest commit	`dc77eb4`
🔍 Latest deploy log	https://app.netlify.com/sites/next-docs-evidence/deploys/672a15b7679f6900084135ca
😎 Deploy Preview	https://deploy-preview-2723--next-docs-evidence.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-11-04T22:33:57Z

✅ Deploy Preview for evidence-test-env ready!

Name	Link
🔨 Latest commit	`dc77eb4`
🔍 Latest deploy log	https://app.netlify.com/sites/evidence-test-env/deploys/672a15b7058a0d00080e96b5
😎 Deploy Preview	https://deploy-preview-2723--evidence-test-env.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

archiewood · 2024-11-04T22:36:13Z

probably need to do a pnpm i to update the lockfile

and pnpm format for the linting

GriffGeorge · 2024-11-04T22:40:10Z

Yea, so, pnpm install seems to work but with some scary peer-dependency warnings. I pushed the new lockfile to the branch anyways. Is this ok?

Long Warning

$ pnpm install
Scope: all 35 workspace projects
 WARN  There are cyclic workspace dependencies: /Users/griffgeorge/src/oss/evidence/packages/lib/sdk, /Users/griffgeorge/src/oss/evidence/packages/lib/universal-sql
packages/extension                       |  WARN  deprecated [email protected]
packages/extension                       |  WARN  deprecated [email protected]
 WARN  deprecated [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.
packages/ui/core-components              |  WARN  deprecated @storybook/[email protected]
packages/ui/core-components              |  WARN  deprecated @storybook/[email protected]
 WARN  27 deprecated subdependencies found: @aws-sdk/[email protected], @humanwhocodes/[email protected], @humanwhocodes/[email protected], @humanwhocodes/[email protected], @humanwhocodes/[email protected], @humanwhocodes/[email protected], @npmcli/[email protected], @npmcli/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Packages: +36 -36
++++++++++++++++++++++++++++++++++++------------------------------------
Progress: resolved 2190, reused 2190, downloaded 0, added 36, done
. postinstall$ run-s build:plugin-connector build:preprocess build:tailwind package:core-components build:evidence
[40 lines collapsed]
│ src/lib -> dist
│ @sveltejs/package found the following issues while packaging your library:
│ Avoid usage of `import.meta.env` in your code. It only works in apps bundled with Vite. Consider using packages like `esm-env` instead which works with all bundlers or without bundling.
│ You are using SvelteKit-specific imports in your code, but you have not declared a dependency on `@sveltejs/kit` in your `package.json`. Add it to your `dependencies` or `peerDependencies`.
│ @evidence-dev/core-components lint results:
│ All good!
│ > @ build:evidence /Users/griffgeorge/src/oss/evidence
│ > pnpm --filter ./packages/evidence build
│ > @evidence-dev/[email protected] build /Users/griffgeorge/src/oss/evidence/packages/evidence
│ > node scripts/build-template
└─ Done in 50.4s
packages/ui/core-components prepare$ svelte-kit sync
└─ Done in 1.5s
 WARN  Issues with peer dependencies found
.
├─┬ @parcel/packager-ts 2.12.0
│ └─┬ @parcel/plugin 2.12.0
│   └─┬ @parcel/types 2.12.0
│     ├── ✕ missing peer @parcel/core@^2.12.0
│     ├── ✕ missing peer @parcel/core@^2.12.0
│     ├── ✕ missing peer @parcel/core@^2.12.0
│     └─┬ @parcel/cache 2.12.0
│       ├── ✕ missing peer @parcel/core@^2.12.0
│       └─┬ @parcel/fs 2.12.0
│         ├── ✕ missing peer @parcel/core@^2.12.0
│         ├── ✕ missing peer @parcel/core@^2.12.0
│         └─┬ @parcel/types 2.12.0
│           ├── ✕ missing peer @parcel/core@^2.12.0
│           └─┬ @parcel/package-manager 2.12.0
│             ├── ✕ missing peer @parcel/core@^2.12.0
│             ├── ✕ missing peer @parcel/core@^2.12.0
│             ├─┬ @parcel/fs 2.12.0
│             │ ├── ✕ missing peer @parcel/core@^2.12.0
│             │ └─┬ @parcel/workers 2.12.0
│             │   └── ✕ missing peer @parcel/core@^2.12.0
│             ├─┬ @parcel/types 2.12.0
│             │ └── ✕ missing peer @parcel/core@^2.12.0
│             └─┬ @parcel/node-resolver-core 3.3.0
│               └── ✕ missing peer @parcel/core@^2.12.0
└─┬ @parcel/transformer-typescript-types 2.12.0
  └── ✕ missing peer @parcel/core@^2.12.0
Peer dependencies that should be installed:
  @parcel/core@">=2.12.0 <3.0.0-0"  

packages/lib/plugin-connector
└─┬ parcel 2.12.0
  └─┬ @parcel/config-default 2.12.0
    └─┬ @parcel/optimizer-htmlnano 2.12.0
      └─┬ htmlnano 2.1.1
        └── ✕ unmet peer svgo@^3.0.2: found 2.8.0

Done in 1m 0.7s

GriffGeorge · 2024-11-04T22:46:23Z

Sorry, I don't know how to fix this. The linting issue is related to the lockfile:

pnpm install --frozen-lockfile --ignore-scripts
  shell: /usr/bin/bash -e {0}
  env:
    PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin
Scope: all [3](https://github.com/evidence-dev/evidence/actions/runs/11673936381/job/32505625577?pr=2723#step:6:3)5 workspace projects
 WARN  There are cyclic workspace dependencies: /home/runner/work/evidence/evidence/packages/lib/sdk, /home/runner/work/evidence/evidence/packages/lib/universal-sql
 WARN  Ignoring not compatible lockfile at /home/runner/work/evidence/evidence/pnpm-lock.yaml
 ERR_PNPM_LOCKFILE_CONFIG_MISMATCH  Cannot proceed with the frozen installation. The current "overrides" configuration doesn't match the value found in the lockfile

Update your lockfile using "pnpm install --no-frozen-lockfile"
Error: Process completed with exit code 1.

I tried pnpm install --no-frozen-lockfile locally, and it exited cleanly, but it didn't change anything, so there's nothing to push. I also tried destroying the lockfile and recreating from scratch, same result.

archiewood · 2024-11-04T23:46:17Z

try deleting the lockfile and node modules and reinstalling

archiewood · 2024-11-13T04:52:24Z

need CI approval

zachstence · 2024-11-13T17:39:39Z

Hi @GriffGeorge there seems to be some sort of breaking change in snowflake-sdk causing our checks to fail because we can't connect to the DB. We're opening an issue with Snowflake to see if they can help out. Unfortunately we won't be able to merge this PR until we get that sorted.

archiewood · 2024-11-13T18:15:00Z

I just tried to reproduce this issue in https://github.com/archiewood/repro-snowflake-ocsp/tree/bumping-version and I cannot - it seems like there is some kind of breaking change, but just in the way that we are using it, not in all ways

GriffGeorge added 2 commits November 4, 2024 17:28

Bump snowflake-sdk to 1.14

967e66e

Merge branch 'next' into bump-snowflake-sdk

ea425a1

GriffGeorge mentioned this pull request Nov 4, 2024

Add Authentication Token caching to Snowflake connector #2701

Merged

4 tasks

lock pnpm

56e5d35

vercel bot had a problem deploying to Preview – next-docs November 4, 2024 22:40 Failure

vercel bot had a problem deploying to Preview – docs November 4, 2024 22:42 Failure

reinstall and rebuild the lockfile

dc77eb4

vercel bot had a problem deploying to Preview – docs November 5, 2024 12:56 Failure

vercel bot had a problem deploying to Preview – next-docs November 5, 2024 12:58 Failure

zachstence self-assigned this Nov 11, 2024

chore: pnpm i

abc4fcd

zachstence marked this pull request as ready for review November 12, 2024 15:09

zachstence requested a deployment to Approval required to run action on external PR November 12, 2024 15:09 — with GitHub Actions Waiting

Merge remote-tracking branch 'upstream/next' into bump-snowflake-sdk

7060996

zachstence temporarily deployed to Approval required to run action on external PR November 12, 2024 15:11 — with GitHub Actions Inactive

vercel bot deployed to Preview – docs November 12, 2024 15:15 View deployment

vercel bot deployed to Preview – next-docs November 12, 2024 15:15 View deployment

Create good-terms-judge.md

ae0ca46

archiewood temporarily deployed to Approval required to run action on external PR November 13, 2024 04:51 — with GitHub Actions Inactive

archiewood requested review from ItsMeBrianD and zachstence November 13, 2024 04:52

vercel bot deployed to Preview – docs November 13, 2024 04:54 View deployment

vercel bot deployed to Preview – next-docs November 13, 2024 04:54 View deployment

Merge remote-tracking branch 'upstream/next' into bump-snowflake-sdk

1429c9e

zachstence temporarily deployed to Approval required to run action on external PR November 13, 2024 17:18 — with GitHub Actions Inactive

zachstence approved these changes Nov 13, 2024

View reviewed changes

vercel bot deployed to Preview – next-docs November 13, 2024 17:21 View deployment

vercel bot deployed to Preview – docs November 13, 2024 17:22 View deployment

zachstence marked this pull request as draft November 13, 2024 17:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump snowflake-sdk to 1.14 #2723

Bump snowflake-sdk to 1.14 #2723

GriffGeorge commented Nov 4, 2024 •

edited

Loading

changeset-bot bot commented Nov 4, 2024 •

edited

Loading

vercel bot commented Nov 4, 2024 •

edited

Loading

netlify bot commented Nov 4, 2024 •

edited

Loading

netlify bot commented Nov 4, 2024 •

edited

Loading

netlify bot commented Nov 4, 2024 •

edited

Loading

archiewood commented Nov 4, 2024

GriffGeorge commented Nov 4, 2024 •

edited

Loading

GriffGeorge commented Nov 4, 2024 •

edited

Loading

archiewood commented Nov 4, 2024 via email •

edited

Loading

archiewood commented Nov 13, 2024 •

edited

Loading

zachstence commented Nov 13, 2024

archiewood commented Nov 13, 2024

Bump snowflake-sdk to 1.14 #2723

Are you sure you want to change the base?

Bump snowflake-sdk to 1.14 #2723

Conversation

GriffGeorge commented Nov 4, 2024 • edited Loading

Description

Checklist

changeset-bot bot commented Nov 4, 2024 • edited Loading

🦋 Changeset detected

vercel bot commented Nov 4, 2024 • edited Loading

netlify bot commented Nov 4, 2024 • edited Loading

❌ Deploy Preview for evidence-development-workspace failed. Why did it fail? →

netlify bot commented Nov 4, 2024 • edited Loading

✅ Deploy Preview for next-docs-evidence ready!

netlify bot commented Nov 4, 2024 • edited Loading

✅ Deploy Preview for evidence-test-env ready!

archiewood commented Nov 4, 2024

GriffGeorge commented Nov 4, 2024 • edited Loading

GriffGeorge commented Nov 4, 2024 • edited Loading

archiewood commented Nov 4, 2024 via email • edited Loading

archiewood commented Nov 13, 2024 • edited Loading

zachstence commented Nov 13, 2024

archiewood commented Nov 13, 2024

GriffGeorge commented Nov 4, 2024 •

edited

Loading

changeset-bot bot commented Nov 4, 2024 •

edited

Loading

vercel bot commented Nov 4, 2024 •

edited

Loading

netlify bot commented Nov 4, 2024 •

edited

Loading

netlify bot commented Nov 4, 2024 •

edited

Loading

netlify bot commented Nov 4, 2024 •

edited

Loading

GriffGeorge commented Nov 4, 2024 •

edited

Loading

GriffGeorge commented Nov 4, 2024 •

edited

Loading

archiewood commented Nov 4, 2024 via email •

edited

Loading

archiewood commented Nov 13, 2024 •

edited

Loading