Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash built parquet files #2860

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Hash built parquet files #2860

wants to merge 2 commits into from

Conversation

csjh
Copy link
Contributor

@csjh csjh commented Nov 27, 2024

Description

Hashes parquet files when projects are built via the evidence cli

The logic here is a bit weird to try to align w/ the process.env.EVIDENCE_DATA_DIR and process.env.EVIDENCE_DATA_URL_PREFIX env vars

The main sketchy part is the static directory "disappearing" when static is copied into the build directory, and since we want to(?) allow custom static directory naming (via svelte.config.js), it's hard to determine the location of manifest.json (though its location is hardcoded as ./static/data/manifest.json in some places which is a whole other problem)

I think if we officially decide you can't have a custom static directory location it can be simplified more (but then I have more complaints about process.env.EVIDENCE_DATA_DIR and process.env.EVIDENCE_DATA_URL_PREFIX

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant