Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tagName of the specified view is not respected #14

Open
denzo opened this issue Mar 5, 2014 · 4 comments
Open

tagName of the specified view is not respected #14

denzo opened this issue Mar 5, 2014 · 4 comments

Comments

@denzo
Copy link

denzo commented Mar 5, 2014

I have a view which is rendered into "tr" tag thus tagName: 'tr'.

At the initial load all the views are rendered correctly (by the way, why all of them are rendered?) and then when I start scrolling they rerender into "div" tag.

Not sure if this is a bug or an incorrect implementation on my side.

@runspired
Copy link

@denzo could you fix your formatting on this question / provide a more in depth example, I was helping another user try to implement cloaked tables and he was bumping into an issue with an extra TR, if I end up with some spare time this weekend I might take a closer peak to see what's needed to make cloaked tables a workable thing.

@denzo
Copy link
Author

denzo commented Feb 11, 2015

@runspired I have fixed the formatting of the question. However, unfortunately I don't have an example as I basically rewrote the whole thing to suit my needs.

@runspired
Copy link

@denzo thanks. P.S. not all the views are rendered anymore. Was there anything else you needed besides that and the TR->DIV conversion?

@runspired
Copy link

@denzo just to let you know, I've updated the es6-flattened branch to easily allow cloaked tables and lists.

the tagName of the cloak-view is editable directly via

{{cloaked-collection itemTagName="li"}}

Alternatively, if the cloaked-collection's tag name is set to tbody or table then the itemTagName will automatically become a tr.

e.g.

{{cloaked-collection tagName="tbody"}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants