Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glimmer and ember-cloaking #42

Open
graffuerchterlich opened this issue Jun 15, 2015 · 3 comments
Open

Glimmer and ember-cloaking #42

graffuerchterlich opened this issue Jun 15, 2015 · 3 comments

Comments

@graffuerchterlich
Copy link

Hey!

I'm curious if ember-cloaking works with Ember 1.13.0 and Glimmer. Can I integrate it with my app, if I'm on Glimmer? Will I see any performance gains or is Glimmer fast enough to render lists of reasonable size?

Thanks for information 😃

@eviltrout
Copy link
Owner

I have yet to try it out! We have a bunch of work to finish on Discourse before we can move to Glimmer.

@rsutphin
Copy link
Contributor

You might want to look at runspired/smoke-and-mirrors. Its occlusion-collection is like ember-cloaking and there's work in progress to get it going with Glimmer.

Will I see any performance gains or is Glimmer fast enough to render lists of reasonable size?

As I understand it, no. Glimmer improves performance for updates. If you just have a big list that's slow to scroll because it's so long, Glimmer won't help very much. But I don't know for sure — I'm still in the process of upgrading my app to try out Glimmer.

@runspired
Copy link

@rsutphin @graffuerchterlich correct, long lists / heavy amounts of DOM still benefit greatly from occlusion (removal of DOM elements that are off screen). The vertical-collection in smoke-and-mirrors works with Glimmer.

Glimmer also improves initial render significantly due to the removal of many of the virtual-view layers, both initial and subsequent renders will improve significantly again post ember 2.0 as the view layer is removed entirely.

I suspect ember-cloaking will have a hard time converting to Glimmer. ContainerView and CollectionView both took a feature hit in 1.13, and will again in 2.0, especially around controlling child views. I'm not sure continuing with them will work at all starting at 2.0.

If you decide to try out smoke-and-mirrors, there's still a decent amount of churn (that will slow down with the 0.3 release coming soon). The APIs are nearly locked, and feature compatibility with ember-cloaking and scrollable divs is 1:1. I discourage using it for scrollable body elements, but a separate solution that works better with scrollable body is coming soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants