Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for JSON authentication responses #8

Open
samfrench opened this issue May 7, 2019 · 1 comment
Open

Suggestion for JSON authentication responses #8

samfrench opened this issue May 7, 2019 · 1 comment

Comments

@samfrench
Copy link
Contributor

  • Do not use the issues tracker for help or support (try Elixir Forum, Slack, IRC, etc.)
  • Questions about how to contribute are fine.

Environment

  • Elixir & Erlang versions (elixir --version):
  • ExAws version mix deps |grep ex_aws
  • HTTP client version. IE for hackney do mix deps | grep hackney

Current behavior

Currently, the STS responses are in XML which is then parsed with SweetXML.

https://github.com/ex-aws/ex_aws_sts/blob/master/lib/ex_aws/sts/parsers.ex

When adding an accept header of "application/json" to the request, a JSON response is returned from the assume_role service. I am not sure if this is applicable to all of the endpoints used in this package.

Expected behavior

Is there any thought about using JSON, or allowing JSON to be requested? This would need another parser as these are all XML based, but this would allow for the dependency of SweetXML to only be used when the service only provides XML.

@koozdra
Copy link
Collaborator

koozdra commented Feb 25, 2020

Could you point to some documentation of json responses? I'm not seeing it in the AWS documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants