Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare temp branch with current (Do not merge) #187

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from
Draft

Compare temp branch with current (Do not merge) #187

wants to merge 33 commits into from

Conversation

tkilias
Copy link
Collaborator

@tkilias tkilias commented Oct 7, 2024 •
edited
Loading

This pull request is only for commenting what we need to extract from this temporary branch

We have changes in two parts in the QueryHandler stuff and the UDF communication. They need to go into separate PR.

For the moment, we will only do the QueryHandler PR and the affected files are marked accordingly. Note, it might be that we also need to merge certain parts from a temporary branch in data_sciencr_utils_python

@tkilias
Add broadcast operation
e28c91b
@tkilias
Add test_gather_broadcast
7219ee1
@tkilias
Add tensorflow example
e5f4e44
@tkilias
Added RetrieveExasolNodeIPAddressUDFDeployer
fe2ee36
@tkilias
Add unit test for udf_communicator and refactored it to make it unit …
c40b1d0 
…testable
@tkilias
Fix integration tests
27088ed
@tkilias
Introduce DistributedUDFRunner and DistributedUDF.
9c76af3
@tkilias
Refactored DistributedTrainingUDF to DistributedUDFRunner and Distrib…
5947f2a 
…utedUDF.
@tkilias
Extracted SocketFactoryContextManagerFactory from udf_communicator.py
39162c0
@tkilias
Added all_gather to Communicator based on gather and broadcast
9a45bea
@tkilias
Extract exchange_cluster_information from distributed_udf.py and refa…
d63caae 
…ctor it with all_gather
@tkilias
Added integration with db for udf_communicator and returned the netwo…
149d6fa 
…rk prefix from RetrieveExasolNodeIPAddressUDF.
@tkilias
Use extracted exchange_cluster_information in distributed_training_ud…
10209bc 
…f.py
@tkilias
Add temporary_udf_name to QueryHandlerContext
4c0c02e
@tkilias
Fix return type of get_temporary_udf_name in QueryHandlerContext
063a27b
@tkilias
Add temporary_connection_name and temporary_name to QueryHandlerContext
e20f283
@tkilias
Use UDFName class in RetrieveExasolNodeIPAddressUDFDeployer
bb5093d
@tkilias
Add language_alias parameter to RetrieveExasolNodeIPAddressUDFDeployer
e00bff3
@tkilias
Extract ConnectionName into its own module to prevent circular import
09233a5
@tkilias
Implement missing abstract function fully_qualified in ConnectionName
25f21d1
@tkilias
Fix MRO in ConnectionNameProxy
9eecf86
@tkilias
Fix _get_temporary_connection_name in _ScopeQueryHandlerContextBase
4b63596
@tkilias
Add MockSQLExecutor which also checks the query to execute against ex…
55cffaa 
…pected queries
@tkilias
Fix name of ExpectedQuery
63fdfb0
@tkilias
Return mock_result_set in MockSQLExecutor
1715daf
@tkilias
use cleandoc in RetrieveExasolNodeIPAddressUDFDeployer
dec8e3d
@tkilias
Improve output of MockSQLExecutor and MockQueryHandlerRunner
6d3dbbe
@tkilias
Use create or replace view in mock_query_handler_runner.py
48a520f
@tkilias
Fix excpeption in mock_sql_executor.py
baece13
@tkilias
Removed tensorflow and some cleanup
e54ee47
tkilias
tkilias commented Oct 7, 2024
View reviewed changes
exasol_advanced_analytics_framework/query_handler/context/connection_name.py
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QueryHandler PR

tkilias
tkilias commented Oct 7, 2024
View reviewed changes
exasol_advanced_analytics_framework/query_handler/context/connection_name_proxy.py
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QueryHandler PR

tkilias
tkilias commented Oct 7, 2024
View reviewed changes
exasol_advanced_analytics_framework/query_handler/context/proxy/drop_udf_query.py
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QueryHandler PR

tkilias
tkilias commented Oct 7, 2024
View reviewed changes
exasol_advanced_analytics_framework/query_handler/context/proxy/udf_name_proxy.py
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QueryHandler PR

tkilias
tkilias commented Oct 7, 2024
View reviewed changes
exasol_advanced_analytics_framework/query_handler/context/query_handler_context.py
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QueryHandler PR

tkilias
tkilias commented Oct 7, 2024
View reviewed changes
exasol_advanced_analytics_framework/query_handler/context/top_level_query_handler_context.py
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QueryHandler PR

tkilias
tkilias commented Oct 7, 2024
View reviewed changes
exasol_advanced_analytics_framework/query_handler/query/drop_connection_query.py
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QueryHandler PR

tkilias
tkilias commented Oct 7, 2024
View reviewed changes
exasol_advanced_analytics_framework/query_handler/query/drop_query.py
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QueryHandler PR

tkilias
tkilias commented Oct 7, 2024
View reviewed changes
exasol_advanced_analytics_framework/query_handler/query/drop_table_query.py
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QueryHandler PR

tkilias
tkilias commented Oct 7, 2024
View reviewed changes
exasol_advanced_analytics_framework/query_handler/query/drop_view_query.py
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QueryHandler PR

tkilias
tkilias commented Oct 7, 2024
View reviewed changes
exasol_advanced_analytics_framework/testing/mock_query_handler_runner.py
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QueryHandler PR

tkilias
tkilias commented Oct 7, 2024
View reviewed changes
exasol_advanced_analytics_framework/udf_utils/testing/mock_sql_executor.py
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QueryHandler PR

tkilias
tkilias commented Oct 7, 2024
View reviewed changes
tests/unit_tests/query_handler/test_scope_query_handler_context.py
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QueryHandler PR

Base automatically changed from refactoring/#176-Updated_bucketfs-python_usage_to_new_API to main October 8, 2024 10:57
@ckunki ckunki mentioned this pull request Oct 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tkilias