Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nox task to check format #280

Merged
merged 9 commits into from
Nov 29, 2024

Conversation

Jannis-Mittenzwei
Copy link
Contributor

Context

you could easily merge code which had formatting errors so we need an automatic formatting check for this problems

Description

This pull request add an nox task which scans the python files for the correct format and is used as a github workflow to check automatically the code for the correct format

@Jannis-Mittenzwei Jannis-Mittenzwei added the feature Product feature label Nov 15, 2024
Copy link
Member

@Nicoretti Nicoretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please always adjust the active GitHub workflows as well as the GitHub workflow templates of the toolbox.

exasol/toolbox/nox/_format.py Show resolved Hide resolved
.github/workflows/checks.yml Outdated Show resolved Hide resolved
Copy link
Member

@Nicoretti Nicoretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update checks template:

exasol.toolbox.templates.checks.yml

Also please add a changelog entry

doc/changes/unreleased.md Outdated Show resolved Hide resolved
doc/changes/unreleased.md Outdated Show resolved Hide resolved
exasol/toolbox/nox/_format.py Show resolved Hide resolved
exasol/toolbox/templates/github/workflows/checks.yml Outdated Show resolved Hide resolved
exasol/toolbox/templates/github/workflows/checks.yml Outdated Show resolved Hide resolved
.github/workflows/checks.yml Outdated Show resolved Hide resolved
.github/workflows/checks.yml Outdated Show resolved Hide resolved
exasol/toolbox/templates/github/workflows/checks.yml Outdated Show resolved Hide resolved
.github/workflows/checks.yml Outdated Show resolved Hide resolved
@Jannis-Mittenzwei Jannis-Mittenzwei merged commit 2449410 into main Nov 29, 2024
25 checks passed
@Jannis-Mittenzwei Jannis-Mittenzwei deleted the feature/add-nox-task-to-check-format branch November 29, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants