Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements / Refactoring #43

Open
Aryk opened this issue Dec 9, 2021 · 0 comments
Open

Improvements / Refactoring #43

Aryk opened this issue Dec 9, 2021 · 0 comments

Comments

@Aryk
Copy link

Aryk commented Dec 9, 2021

I'm not sure there is much activity on this gem.

I've been getting different errors not capable of being handled by this gem and see tons of deprecated stuff.

So I thought I would just take this gem and tear it a new one, fix a few problems and just make it easier to parse and understand.

Improvements:

  1. Added support for PUSH_TOO_MANY_EXPERIENCE_IDS (including tests) error so you'll actually see if you are getting that error.
  2. Whenever there is an unknown error, I always add the actual error message onto it so you can see what exactly failed in the code. I also pass through the details into the error message so you know what went wrong by the error message.
  3. Allow the ability to pass in options for Typheous.post so you don't have to pass in a different HTML client, so for example you can now pass in ssl_verifypeer: false to get the gem working in AWS if you are in that environment.
  4. Removed the deprecated methods.

Changes are here:

https://github.com/tribefyhq/expo-server-sdk-ruby

Maybe it's helpful for someone here.

@Aryk Aryk changed the title 0.20 Forked With Improvements Improvements / Refactoring Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant