Skip to content
This repository has been archived by the owner on Feb 15, 2019. It is now read-only.

Support drawer headings, separators, and account drawers #227

Open
dantman opened this issue Nov 8, 2016 · 6 comments
Open

Support drawer headings, separators, and account drawers #227

dantman opened this issue Nov 8, 2016 · 6 comments

Comments

@dantman
Copy link

dantman commented Nov 8, 2016

DrawerNavigation/DrawerNavigationItem is extremely limited at the moment, it can only handle items.

It can't handle headings or separators which are not touchable items in the {left, title, right} format.
screenshot_20161107-203208

Nor can it handle drawer layouts where a button in the header changes the drawer items, namely for signin/account purposes.
screenshot_20161107-203212

The best way to handle the first would probably be an alternative to DrawerNavigationItem that generically renders its children into the drawer.

The second will either require more flexibility in the drawer rendering to allow custom rendering or explicit support for that Material style account drawer.

@brentvatne
Copy link
Member

This would be really nice, I only implemented the minimum that I need for my use case, open to ideas for how to make the api more comprehensive and flexible!

@sibelius
Copy link
Contributor

sibelius commented Nov 8, 2016

@dantman custom render of drawerMenu can be achieve using renderNavigationView introduce it here: #182

@dantman
Copy link
Author

dantman commented Nov 8, 2016

@sibelius Ok, thanks. That's a start for the custom rendering. Being able to implement a signin menu will require a little more, probably some level of ability to filter and wrap rendering of items.

Something will need to be done about the styles in ExNavigationDrawerLayout as well.

@dantman
Copy link
Author

dantman commented Nov 10, 2016

#234 I've implemented a <DrawerNavigationChild> that can be used to insert non-items into the drawer.

@dantman
Copy link
Author

dantman commented Nov 24, 2016

When #251 is merged I'm already ready to submit another pull request implementing support for the last things needed for the account drawer.

@jkeam
Copy link

jkeam commented Apr 29, 2017

Waiting with bated breath :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants