Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup dynamic height expanding under tab bar view #201

Open
alexantonica opened this issue Jul 14, 2024 · 1 comment
Open

Popup dynamic height expanding under tab bar view #201

alexantonica opened this issue Jul 14, 2024 · 1 comment

Comments

@alexantonica
Copy link

alexantonica commented Jul 14, 2024

I'm on the latest commit testing on ios 17+
A few weeks ago this was working fine, but now I see this happening. I tried using older commits but it didn't seem to fix it so I guess it's not necessarily the library at fault here, but I have no other ideas what to try.

I use a floater popup, when it appears, it shows right above the tab bar view, which is correct. If i select an image and increase the height of the floater window, the view expands downwards under the tab bar view items.

What I would expect and what was happening before was that the view would expand upwards, so it'll always have the safe area inset padding.

I tried setting the vertical padding for the floater when i select the image, but the view doesn't update.

Any ideas? 🙏

My setup is something like

TabBar view {
    SomeView()
      .popup( AnotherView(), customise: 
      {
    $0
        .type(.floater(verticalPadding: verticalPadding))
        .position(.bottom)
        .closeOnTap(false)
        .closeOnTapOutside(false)
        .dragToDismiss(true)
        .backgroundColor(.black.opacity(0.4))
       })
}

RocketSim_Recording_iPhone_15_Pro_6 1_2024-07-14_18 03 27-ezgif com-crop

EDIT: Added an example project where i could reproduce it

PopupTestApp.zip

@alexantonica
Copy link
Author

Updated with example project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant