Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve animation quality. #257

Closed

Conversation

luriusTM
Copy link
Contributor

Changed:

  • Preview delayed from 0.4s to 0.8s (after 0.6 it is resting time as UX defines)
  • Animation time 100ms to 300ms (200ms to 500ms could be targeted)
  • animation flow from custom cubic bazier to linear (width & height animation which grows and shrinks, it is more natural and has to move together - when shrink and when grow).
  • Animation breaks got covered (separations broke animations, it is not now)

@eythaann
Copy link
Owner

300ms is too slow, the change needed here is implement a capture of mouse position. this is not priority and I have to search a lightweight version of it, like it was before but I removed it cuz when the laptop was on low power, or eco mode the dock becomes soo lagy while capturing the mouse and making operations, The last time I forgot add a fps limit, so currently on collitions boxed I use 15fps for mouse, so maybe this could work fine without make lagy the dock, speed is preferred over "smoothness" so the current one is fine like users normally move the mouse fast not slowly.

@eythaann
Copy link
Owner

the best solution in cons the last one could be only capture de mouse position on js and exposed like css variables and make the animation via css and not using js.

@eythaann eythaann closed this Oct 27, 2024
@luriusTM
Copy link
Contributor Author

luriusTM commented Oct 27, 2024

I do not agree, just for this animation I would not make such amount of work. If you look on refered issue thread, there is a preview of this solution. I think it is gone smooth and nothing js magic needed. just minor animation property set and extension of selectors.

Although, as you think, i do not have major problem with the current animation by myself :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants