Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8079: Inconsistent redirect point after role assignment action #2118

Conversation

vidarl
Copy link
Member

@vidarl vidarl commented Apr 23, 2024

Question Answer
Tickets IBX-8079
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Dealing with assignments in Role configurations, redirects you to the "Policies" tab after every action. The "Assigments" tab should automatically be selected after adding/removing role assigments

For instance, when clicking the "Delete" button in the modal below, the user should see the content of the "Assigments" tab when the page refreshes
image

Note when merging up: Anchor is named ibexa-tab-users-and-groups (not users-and-groups) in Ibexa 4.x

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mikadamczyk mikadamczyk requested a review from a team June 12, 2024 14:33
@konradoboza konradoboza requested a review from a team June 13, 2024 06:17
@webhdx webhdx requested a review from a team June 13, 2024 06:34
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on Ibexa Commerce 3.3.38-dev.
Diff ok.

@micszo micszo removed their assignment Jul 2, 2024
@Nattfarinn Nattfarinn merged commit 7d1971c into 2.3 Jul 2, 2024
14 checks passed
@Nattfarinn Nattfarinn deleted the IBX-8079_Inconsistent_redirect_point_after_role_assignment_action branch July 2, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

9 participants