Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client doesn't verify EscrowRegistration response against local contract #10

Open
f321x opened this issue Aug 31, 2024 · 0 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@f321x
Copy link
Owner

f321x commented Aug 31, 2024

The client currently accepts escrow conditions locked as soon as it gets a response from the coordinator after submitting the contract. This could lead to the client accepting a EscrowRegistration even though it is of a different contract. A simple check of the local contract hash against the returned escrow_id_hex in EscrowRegistration sent by the coordinator solves this.

@f321x f321x added enhancement New feature or request good first issue Good for newcomers labels Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant