Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolling camera and then interacting with the view provide incorrect interactions #1741

Open
mwestphal opened this issue Nov 29, 2024 · 4 comments
Assignees
Labels
source:libf3d type:bug Something isn't working
Milestone

Comments

@mwestphal
Copy link
Contributor

Describe the bug
Rolling the camera (by pressing 6) and then interacting with the mouse is incorrect.
The camera "jerks" back to the original position.

To Reproduce
Steps to reproduce the behavior:

  1. Open the file using f3d --dry-run dragon.vtu
  2. press 6
  3. interact with view

Expected behavior
No jerking

@mwestphal mwestphal added this to F3D Nov 29, 2024
@mwestphal mwestphal moved this to Investigate in F3D Nov 29, 2024
@mwestphal mwestphal added this to the 3.0.0 milestone Nov 29, 2024
@mwestphal mwestphal added type:bug Something isn't working source:libf3d labels Nov 29, 2024
@mwestphal mwestphal self-assigned this Dec 4, 2024
@mwestphal
Copy link
Contributor Author

Caused by

    // orthogonalize up vector based on focal direction
    vtkMath::MultiplyScalar(dir, dot);
    vtkMath::Subtract(up, dir, dir);
    vtkMath::Normalize(dir);
    camera->SetViewUp(dir);

in /vtkF3DInteractorStyle.cxx

Since rolling camera does not impact view-up, im not sure of the right way to fix this.

TopViewCamera as the same issue

@mwestphal mwestphal moved this from Investigate to Discuss in F3D Dec 18, 2024
@mwestphal mwestphal removed their assignment Dec 18, 2024
@mwestphal
Copy link
Contributor Author

No obvous fix, moving back

@mwestphal mwestphal modified the milestones: 3.0.0, 3.1.0 Dec 19, 2024
@samoncrief
Copy link
Contributor

I'm looking into this now, feel free to assign it to me

@mwestphal
Copy link
Contributor Author

Sure, assigned.

A possible implementation is to store a temporary view-up when rolling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source:libf3d type:bug Something isn't working
Projects
Status: Discuss
Development

No branches or pull requests

2 participants