removing not relevant code (to be tested)

fabOnReact · Nov 11, 2022 · 41173cb · 41173cb
1 parent 3b16542
commit 41173cb
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 17 deletions.
diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManagerDelegate.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManagerDelegate.java
@@ -7,7 +7,6 @@
 
 package com.facebook.react.uimanager;
 
-import android.util.Log;
 import android.view.View;
 import androidx.annotation.Nullable;
 import com.facebook.react.bridge.ColorPropConverter;
@@ -31,8 +30,6 @@ public BaseViewManagerDelegate(U viewManager) {
 
   @Override
   public void setProperty(T view, String propName, @Nullable Object value) {
-    Log.w("TESTING::BaseViewManagerDelegate", "propName: " + (propName));
-    Log.w("TESTING::BaseViewManagerDelegate", "value: " + (value));
     switch (propName) {
       case ViewProps.ACCESSIBILITY_ACTIONS:
         mViewManager.setAccessibilityActions(view, (ReadableArray) value);

diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManager.java
@@ -19,7 +19,6 @@
 import android.text.StaticLayout;
 import android.text.TextPaint;
 import android.util.LayoutDirection;
-import android.util.Log;
 import android.util.LruCache;
 import android.view.View;
 import androidx.annotation.NonNull;

diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactMapBufferPropSetter.kt b/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactMapBufferPropSetter.kt
@@ -6,7 +6,7 @@
  */
 
 package com.facebook.react.views.view
-import android.util.Log;
+
 import android.graphics.Color
 import android.graphics.Rect
 import androidx.core.view.ViewCompat
@@ -64,7 +64,6 @@ object ReactMapBufferPropSetter {
   private const val VP_POINTER_OVER_CAPTURE = 44
   private const val VP_BORDER_CURVES = 45 // iOS only
   private const val VP_FG_COLOR = 46 // iOS only?
-  private const val VP_ACCESSIBILITY_UNIT = 47
 
   // Yoga values
   private const val YG_BORDER_WIDTH = 100
@@ -108,7 +107,6 @@ object ReactMapBufferPropSetter {
   private const val UNDEF_COLOR = Int.MAX_VALUE
 
   fun setProps(view: ReactViewGroup, viewManager: ReactViewManager, props: MapBuffer) {
-    Log.w("TESTING::ReactMapBufferPropSetter", "props: " + ( props ));
     for (entry in props) {
       when (entry.key) {
         VP_ACCESSIBILITY_ACTIONS -> {
@@ -132,9 +130,6 @@ object ReactMapBufferPropSetter {
         VP_ACCESSIBILITY_STATE -> {
           viewManager.accessibilityState(view, entry.mapBufferValue)
         }
-        VP_ACCESSIBILITY_UNIT -> {
-          viewManager.setAccessibilityUnit(view, entry.stringValue.takeIf { it.isNotEmpty() })
-        }
         VP_ACCESSIBILITY_VALUE -> {
           viewManager.accessibilityValue(view, entry.stringValue)
         }
@@ -283,12 +278,6 @@ object ReactMapBufferPropSetter {
     ViewCompat.setAccessibilityLiveRegion(this, mode)
   }
 
-  private fun ReactViewManager.accessibilityUnit(view: ReactViewGroup, value: String) {
-    Log.w("TESTING::ReactMapBufferPropSetter", "accessibilityUnit");
-    Log.w("TESTING::ReactMapBufferPropSetter", "value: " + ( value ));
-    setAccessibilityUnit(view,"random string")
-  }
-
   private fun ReactViewManager.accessibilityState(view: ReactViewGroup, value: MapBuffer) {
     val accessibilityState = JavaOnlyMap()
     accessibilityState.putBoolean("selected", value.getBoolean(ACCESSIBILITY_STATE_SELECTED))

diff --git a/ReactCommon/react/renderer/components/view/AccessibilityProps.h b/ReactCommon/react/renderer/components/view/AccessibilityProps.h
@@ -39,7 +39,7 @@ class AccessibilityProps {
 
   bool accessible{false};
   AccessibilityState accessibilityState;
-  std::string accessibilityUnit{"1"};
+  std::string accessibilityUnit{""};
   std::string accessibilityLabel{""};
   AccessibilityLabelledBy accessibilityLabelledBy{};
   AccessibilityLiveRegion accessibilityLiveRegion{