Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic logfile rotation seems to be missing #69

Open
mpvader opened this issue May 26, 2024 · 3 comments
Open

Automatic logfile rotation seems to be missing #69

mpvader opened this issue May 26, 2024 · 3 comments

Comments

@mpvader
Copy link

mpvader commented May 26, 2024

Hi!

as dbus-shelly is now, I expect every user using it will run into trouble (full data partition, a really bad situation) at some point.

see see henne49/dbus-opendtu#173 for how I recommend to fix it.

Matthijs / Victron

@mpvader
Copy link
Author

mpvader commented Jun 1, 2024

Hey @Kotty666 , since you worked on this before, can I interest you in getting this fixed?

many people are copying this repo, and it is causing issue for us.

50Mb is also too much.

please make the code write to stdout instead of making its own log file - see above link.

@Kotty666
Copy link
Contributor

Kotty666 commented Jun 1, 2024

@mpvader should be possible just done this few days ago at my dbus-growatt-shinex repository. But the interesting thing would be if @fabian-lauer had enough time to merge the request.

@Kotty666
Copy link
Contributor

Kotty666 commented Jun 1, 2024

I've changed the needed stuff and createt a PR (#71 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants