Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Add support for local login #584

Open
hemanik opened this issue Aug 7, 2018 · 4 comments
Open

Add support for local login #584

hemanik opened this issue Aug 7, 2018 · 4 comments

Comments

@hemanik
Copy link
Contributor

hemanik commented Aug 7, 2018

Expected behavior

In the case of local setup, the user should be able to login with a local Oauth server instead of keycloak. With the login workflow as described below:

  • UI calls Auth
  • Auth responds to UI with a url as a 307
  • UI asks user to login by redirecting to the url returned above.
  • The local oauth server calls Auth with /code=XYZ
  • ( behind the scene ) Auth calls the local oauth server to get a token by presenting the code
  • Auth responds to the local oauth server with a 307 and location=localhost:3000?token=XYZ
  • The local oauth sends the user to localhost:3000?token=XYZ
@hemanik hemanik self-assigned this Aug 7, 2018
@hemanik hemanik added this to the Sprint 153-2 milestone Aug 7, 2018
@sbose78 sbose78 changed the title Add login support with Minishift for the local setup. Add support for local login Aug 7, 2018
@sbose78
Copy link
Member

sbose78 commented Aug 10, 2018

In order of preference

  1. Explore an option of 'mock' oauth server that could be run locally with minimal config --> zero code change on login side.
  2. If (1) doesn't work out, run a keycloak remotely with a public client to provide login via github. --> zero code change on login side.
  3. Make code changes on login side to not depend on the identity provider to return a JWT. This has long term benefits - but in the short term, i will try to avoid making any code changes.

@xcoulon xcoulon modified the milestones: Sprint 153-2, Sprint 153-3 Aug 14, 2018
@xcoulon xcoulon modified the milestones: Sprint 153-3, Sprint 154-1 Aug 22, 2018
@xcoulon
Copy link
Contributor

xcoulon commented Aug 23, 2018

The code for @hemanik's standalone OAuth service is at https://github.com/fabric8-services/go-oauth2-jwt

@xcoulon xcoulon modified the milestones: Sprint 154-1, Sprint 154-2, Sprint 154-3 Aug 28, 2018
@xcoulon xcoulon modified the milestones: Sprint 154-3, Sprint 155-1 Sep 10, 2018
@xcoulon
Copy link
Contributor

xcoulon commented Sep 13, 2018

Moving to backlog as priority is lower for now.

@sbryzak
Copy link
Member

sbryzak commented Jan 25, 2019

Still a low priority as of Jan 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants