Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit testing #14

Open
freemvmt opened this issue Nov 8, 2019 · 0 comments
Open

Unit testing #14

freemvmt opened this issue Nov 8, 2019 · 0 comments
Labels
bug Something isn't working compliment

Comments

@freemvmt
Copy link

freemvmt commented Nov 8, 2019

Hey team!

Great work on your project. All the logic seems to work really well, at least from playing around with the actual page.

However 2/9 of your tests are still failing! Specifically these ones, which relate to your addTodo function:

  • Should leave input argument unchanged
  • Should add an id to newObject

I could be wrong about this one but I think another test called 'test done property has been changed' doesn't actually test anything? It's just comparing two objects you have declared above, whereas I think the actual should be given by running the markTodo function on your toDoInput?

Presumably the markTodo function is working though, since you have nice effects when I tick the complete box on the actual page!

@bethanyios bethanyios added bug Something isn't working compliment labels Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compliment
Projects
None yet
Development

No branches or pull requests

2 participants