Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Snapshot Test reference images differ on Circle CI #27801

Closed
hramos opened this issue Jan 17, 2020 · 4 comments
Closed

[CI] Snapshot Test reference images differ on Circle CI #27801

hramos opened this issue Jan 17, 2020 · 4 comments
Labels
Bug Component: Image p: Facebook Partner: Facebook Ran Commands One of our bots successfully processed a command. RN Team Stale There has been a lack of activity on this issue and it may be closed soon. 🔩Test Infrastructure Test infrastructure and continuous integration.

Comments

@hramos
Copy link
Contributor

hramos commented Jan 17, 2020

We're tracking a known issue where the snapshot test reference images differ slightly when generated on Circle CI as compared to a regular macOS install when Xcode 11 is used. We suspect this might be related to the use of the GPU by the simulator, a feature that is new to Xcode 11 (see similar issue at uber/ios-snapshot-test-case#109). This is based off the assumption that the way Circle CI handles macOS jobs might not provide access to a GPU.

Snapshot tests will be disabled on Circle CI until this issue is resolved.

Reference

The actual differences between the images are imperceptible to the naked eye, and may be attributed to slight differences in how the views are rendered on and off GPU.

This is the diff for testSwitchExample:

Screen Shot 2020-01-17 at 10 33 01 AM

These are the two images, side by side:
Screen Shot 2020-01-17 at 12 56 56 PM

@hramos hramos added 🔩Test Infrastructure Test infrastructure and continuous integration. ❌CI Test Failure Bug RN Team labels Jan 17, 2020
@facebook facebook deleted a comment from react-native-bot Jan 31, 2020
@pigeon56
Copy link

pigeon56 commented Apr 24, 2020

I just updated to Catalina / Xcode 11.4.1 about a week ago, and my tests (iOS Snapshot tests run via Circle CI) started breaking. The issue that you describe here seems to be what I'm encountering. Do you have any updates on this?

Thanks in advance.

@fabOnReact
Copy link
Contributor

@ChiWhiteSox56 I'm on Ubuntu 19.10 and I am following the Docker Instructions writter from Hector Ramos. 😃 Thanks a lot for the amazing instructions. Could not make it without them.

@stale
Copy link

stale bot commented Aug 8, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Aug 8, 2020
@stale
Copy link

stale bot commented Aug 16, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Aug 16, 2020
@facebook facebook locked as resolved and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Component: Image p: Facebook Partner: Facebook Ran Commands One of our bots successfully processed a command. RN Team Stale There has been a lack of activity on this issue and it may be closed soon. 🔩Test Infrastructure Test infrastructure and continuous integration.
Projects
None yet
Development

No branches or pull requests

4 participants