Update docs on usePaginationFragement & transitions in Relay tutorial. #4842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found out that `useTransition` doesn't work when using `usePaginationFragement`. To get it to work the way it's intended in the tutorial I had to use `isLoadingNext` boolean prop that is returned from `usePaginationFragement` instead. Not sure if this a bug, or by design. As a beginner, I spent quite some time trying to figure out why my code wasn't working, after a bit of digging I ran into some potenially related issues: - facebook#4531 (comment) - facebook#4526 - facebook#3082 In this PR I've updated the "Improving the Loading Experience with useTransition" example not to confuse newcomers.
danielstocks
changed the title
|
Sorry for the confusion this caused! I'll import and we can look into if this is expected behavior or not. |
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out that
useTransitiondoesn't work when usingusePaginationFragement. To get it to work the way it's intended in the tutorial I had to useisLoadingNextboolean prop that is returned fromusePaginationFragementinstead. Not sure if this a bug, or by design.As a beginner, I spent quite some time trying to figure out why my code wasn't working, after a bit of digging I ran into some potenially related issues:
refetch({}, "network-only")suspends, even when insidestartTransition#4526In this PR I've updated the code in "Improving the Loading Experience with useTransition" example not to confuse newcomers. Also the section about "results that aren’t immediate should be wrapped in a React transition" as it no longer applies in this particular context.
I also replaced
<CommentsLoadingSpinner />(which doesn't exist?) with<SmallSpinner />which seems more appropriate in the particular example.