Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A potential null pointer dereference bug. Please confirm, much appreicated! #681

Open
HermioneSW opened this issue Apr 8, 2020 · 1 comment
Open

A potential null pointer dereference bug. Please confirm, much appreicated! #681

HermioneSW opened this issue Apr 8, 2020 · 1 comment

Comments

@HermioneSW
Copy link

HermioneSW commented Apr 8, 2020 •
edited
Loading

Hi,

We are developing a new static analysis tool for catching bugs in Java code. Upon scanning your codebase we find the following:

In Frame.java (stetho/src/main/java/com/facebook/stetho/websocket/Frame.java) line 41, if hasMask is false then maskingKey will be assigned null when passed to MaskingHelper.unmask(maskingKey, payloadData, 0, (int)payloadLen) the expression key[index++ % key.length] at line 14 in MaskingHelper.java will trigger a null pointer dereference.

Would you please take a look and confirm this is indeed a bug? Thanks a million!!!
@HermioneSW
Copy link
Author

Hi, can anyone please take a look at the issue and confirm this is indeed a bug? Thanks a million!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HermioneSW