-
Notifications
You must be signed in to change notification settings - Fork 906
Change the Facebook SDK to version 9 #833
base: master
Are you sure you want to change the base?
Conversation
update fbsdk version
update fbsdk version
bugfix
Hi @zhantx! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
@@ -33,5 +33,6 @@ allprojects { | |||
google() | |||
jcenter() | |||
maven { url 'https://www.jitpack.io' } | |||
mavenCentral() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like to know why is this needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I put mavenCentral
in the package's build.gradle, it won't find the facebook-android-sdk:9. I had to put it in rout project level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tanks for the explanation.
Just take a look to the README.md
, this might be missing for a long time.
+1 |
@zhantx please hit this CLA https://github.com/facebook/react-native-fbsdk/pull/833/checks?check_run_id=1831428073 |
Finished |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
thanks for all the incredible work with regards to fb sdk 9.0 @zhantx. Does anyone know when this will get merged and the next release published? |
Waiting for merge... |
Please take a full review of the conversations in #832, it seems like it will never be merged because Facebook is not going to maintain this package anymore. For anyone who is waiting for this to be merged, I would recommend just Or you can just add it from our forked repo, our repo include commits from this PR. (Thanks @zhantx) To install: There are also two changes we have done:
|
@janicduplessis can you review this? We need the SDK upgrade on this package, please! |
Changes in upgrading FB SDK version from: facebookarchive/react-native-fbsdk#833
Please let us know when this is going to merge in the package? |
Change the Facebook SDK to version 9. Given there is no breaking changes, all API should work as previous.
Fixes #832