Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::string tests need updating for treebuilder v2 #311

Open
JakeHillion opened this issue Aug 21, 2023 · 0 comments
Open

std::string tests need updating for treebuilder v2 #311

JakeHillion opened this issue Aug 21, 2023 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed library An issue specific to the OI Library (OIL). testing

Comments

@JakeHillion
Copy link
Contributor

std::string has been updated and the output looks correct but the tests are failing. This likely means they need updating for TreeBuilder v2 due to the slightly different output format.

Examples:

  • OilIntegration.std_string_empty
  • OilIntegration.std_string_sso
  • OilIntegration.std_string_heap_allocated
@JakeHillion JakeHillion added good first issue Good for newcomers help wanted Extra attention is needed testing library An issue specific to the OI Library (OIL). labels Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed library An issue specific to the OI Library (OIL). testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JakeHillion