Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect testing advice in PR template #363

Open
JakeHillion opened this issue Sep 22, 2023 · 0 comments
Open

Incorrect testing advice in PR template #363

JakeHillion opened this issue Sep 22, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@JakeHillion
Copy link
Contributor

The PR template currently suggests running make test-static and pasting the output. External contributors don't have this Makefile, and it wasn't great advice to begin with. We should update this to something more useful or tell people to rely on the CI for now, unless they've done some specialised testing.
@JakeHillion JakeHillion added the documentation Improvements or additions to documentation label Sep 22, 2023
@JakeHillion JakeHillion mentioned this issue Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JakeHillion