Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in Feed Topic Construction and POD_TOPIC Constant #488

Open
IgorShadurin opened this issue May 8, 2023 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@IgorShadurin
Copy link
Collaborator

The feed topic construction for arbitrary strings in the documentation uses the keccak256 hashing function, as mentioned here: https://github.com/fairDataSociety/FIPs/blob/master/text/0061-personal-storage.md?plain=1#L170

However, in FDP Storage (and thereby in FairOS), the topic is calculated using the BMT Hash of the arbitrary string for every topic.

This introduces additional complexity and computational overhead without any apparent benefit.

Moreover, the POD_TOPIC constant has the value Pods in the library, which is inconsistent with the FIP version PODs.

Expected behavior:

  • The feed topic construction should use the keccak256 hashing function as specified in the documentation.
  • The POD_TOPIC constant should be consistent with the FIP version.

JS implementation: fairDataSociety/fdp-storage#223

@IgorShadurin IgorShadurin added the enhancement New feature or request label May 8, 2023
@asabya asabya removed their assignment Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants