fix: plugin_loader compilation errors across different version of glibc #81
+169
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't declare this func, since it may be already declared. We will switch to a internal declaration only for the plugin loader. Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
leogr
force-pushed
the
fix/plugin-loader-compilation-errors
branch
from
f489e30
to
3396f99
Compare
leogr
changed the title
|
/kind bug |
poiana
added
kind/bug
jasondellaluce
approved these changes
Aug 30, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
This is a follow-up PR for #80
Unfortunately, #80 worked only for glibc >= 2.38. This PR always uses the same
strlcpyinternal implementation, so it works in any case.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Since we don't use cmake here, we can't just decide a built time which declaration to use (as we do in libs)
Does this PR introduce a user-facing change?: