You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 25, 2024. It is now read-only.
So finally I think that things can settle down and go back to business as usual here.
I have procrastinated this name change for a long time, beq I didn't really know how to do is best.
Lesson learned:
Always take care of PR's before renaming the modulename... PR's against master gets broekn big when the file isn't there anymore.. So the PR's went full bork, and I had to do all the diff manually against the old code.
setup.py is pretty important.. "doh". py_module is tha module name.. not the package name...
Autobuild releases with actions on Github can be challenging if things aren't pristine in the release code.
What should I have done different.
Perhaps created a fork of the repo with the new name. instead of doing a defork and rename.
In hindsight that feels like a cleaner way. Then it would be easy to make the old "ise" package on pypi depricated with the github repo archived.
But, now we are here and I'll try to get this package published to devnet with the new name.
If you have any ideas or thoughts do not hesitate to contact me.
And if I have messed up your PR, I'm really sorry for that.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Hello,
So finally I think that things can settle down and go back to business as usual here.
I have procrastinated this name change for a long time, beq I didn't really know how to do is best.
Lesson learned:
What should I have done different.
Perhaps created a fork of the repo with the new name. instead of doing a defork and rename.
In hindsight that feels like a cleaner way. Then it would be easy to make the old "ise" package on pypi depricated with the github repo archived.
But, now we are here and I'll try to get this package published to devnet with the new name.
If you have any ideas or thoughts do not hesitate to contact me.
And if I have messed up your PR, I'm really sorry for that.
--
Kind Regards Falk
Beta Was this translation helpful? Give feedback.
All reactions