Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate how the wrong user ID could be set #29

Open
wbazant opened this issue Jul 12, 2024 · 3 comments
Open

Investigate how the wrong user ID could be set #29

wbazant opened this issue Jul 12, 2024 · 3 comments
Assignees
Labels

Comments

@wbazant
Copy link

wbazant commented Jul 12, 2024

Found when looking at spammy location 1989978 .

Screenshot from 2024-07-12 12-11-09
Screenshot from 2024-07-12 12-10-15

Live site says it was an anonymous add but beta says 'Added by Tống Thái Vương', who I remember added the Vietnamese translation and added lots of locations, so it's probably not them.

@ezwelty ezwelty added the bug label Aug 12, 2024
@ezwelty ezwelty self-assigned this Aug 12, 2024
@ezwelty
Copy link
Contributor

ezwelty commented Aug 19, 2024

The API and new website uses the current user name of the associated user to populate "author", while the old website hardcodes "author" when the location/review is created based on the form (which by default is filled with user name if logged in). This location was added via the old website and has no "author" set (hence anonymous on the old website), but for reasons I cannot explain, has a user id set (hence the user name on the new website). Disturbing, but this is not an issue with the API.

@wbazant
Copy link
Author

wbazant commented Aug 19, 2024

I think I've spotted another one of these? It says "Added by Ethan" - so I'm guessing it has your user ID in the database - but the location is not likely to have been you: 1909048

@ezwelty
Copy link
Contributor

ezwelty commented Aug 20, 2024

@wbazant False positive. That was me! 😄

@ezwelty ezwelty transferred this issue from falling-fruit/falling-fruit-web Oct 1, 2024
@ezwelty ezwelty changed the title 'Added by' incorrect in beta site Investigate how the wrong user ID could be set Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants