Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SectionAlignment #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix SectionAlignment #94

wants to merge 1 commit into from

Conversation

HotKeyIt
Copy link

@HotKeyIt HotKeyIt commented Mar 15, 2019 •
edited
Loading

Some dlls do not use Native SectionAlignment, instead use SectionAlignment from PE.
Issue 54 should be solved then: #54

@HotKeyIt
Fix SectionAlignment
fd6ae57 
Some dlls do not use Native SectionAlignment, instead use SectionAlignment from PE.
@Elmue
Copy link

Elmue commented Jul 2, 2020

I have never seen such a DLL.
But your fix is correct.

@FuPeiJiang
Copy link

does this work without changing
result->pageSize = sysInfo.dwPageSize; to result->pageSize = old_header->OptionalHeader.SectionAlignment ?

module->pageSize is referenced multiple times,
but now it's undefined because the call to GetNativeSystemInfo(&sysInfo); has been removed,
or is SYSTEM_INFO sysInfo; initialized to zero ? I'm not sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HotKeyIt @Elmue @FuPeiJiang