Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numeric Block is limited to n <= 999 and munges input #414

Open
michaeltlombardi opened this issue Jul 18, 2022 · 0 comments
Open

Numeric Block is limited to n <= 999 and munges input #414

michaeltlombardi opened this issue Jul 18, 2022 · 0 comments
Assignees
@RPDeshaies
Labels
bug Something isn't working

Comments

@michaeltlombardi
Copy link

🚩 Describe the bug

Using the Numeric block to track large numbers, such as coins or XP, is not possible in the current UI. Specifying a number greater than 999 in the numeric's input field munges the value to 999. Even when exported, the data is 999 instead of the actual input.

🔢 Steps to reproduce

  1. Create new character.
  2. Add new section.
  3. Add Numeric block.
  4. Type 1000 and it is munged to 999.

🟢 Expected behavior

It is possible to track large numbers when required.

🔴 Actual behavior

Any number greater than 999 is munged to 999.

💅 Screenshots

fari-numeric-limit

🖥 Desktop or Smartphone

  • OS: Windows 10
  • Browser: Chrome
  • Device: Desktop

📄 Additional context

I suspect this is because the Numeric's display will only show up to three digits comfortably. I think a secondary block or option on the block for larger numbers would be useful here.
@michaeltlombardi michaeltlombardi added the bug Something isn't working label Jul 18, 2022
glmdgrielson added a commit to glmdgrielson/fari-app that referenced this issue Nov 4, 2024
@glmdgrielson
Revamp numeric text field
9900754 
This SHOULD fix bug farirpgs#414, in a way that doesn't look too bad.
@glmdgrielson glmdgrielson mentioned this issue Nov 4, 2024
Merged
RPDeshaies added a commit that referenced this issue Nov 5, 2024
@glmdgrielson @RPDeshaies
Revamp numeric text field (#550)
9dc2d3c 
This SHOULD fix bug #414, in a way that doesn't look too bad.

## ✅ Changes

<!-- Use prefixes: **chore**, **docs**, **feat**, **fix**, **refactor**,
**style** or **test** -->

- **refactor**: change the text display used for numeric text inputs.

## 🌄 Context

Per bug #414, the prior version had a limit on how large the value in
the field could be.

## 🔒Checklist

- I tested my work on the feature environment

---------

Co-authored-by: rpdeshaies <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RPDeshaies RPDeshaies

Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RPDeshaies @michaeltlombardi