Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable test on CI #9

Open
andylokandy opened this issue Jul 23, 2024 · 4 comments
Open

Unstable test on CI #9

andylokandy opened this issue Jul 23, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@andylokandy
Copy link
Collaborator

andylokandy commented Jul 23, 2024

thread 'test_macro_properties' panicked at fastrace/tests/lib.rs:756:5:
assertion `left == right` failed
  left: "\nroot []\n    bar_async []\n    foo_async [(\"k1\", \"v1\"), (\"a\", \"argument a is 1\"), (\"b\", \"Bar\"), (\"escaped1\", \"Bar{}\"), (\"escaped2\", \"{ \\\"a\\\": \\\"b\\\"}\")]\n"
 right: "\nroot []\n    bar []\n    bar_async []\n    foo [(\"k1\", \"v1\"), (\"a\", \"argument a is 1\"), (\"b\", \"Bar\"), (\"escaped1\", \"Bar{}\"), (\"escaped2\", \"{ \\\"a\\\": \\\"b\\\"}\")]\n    foo_async [(\"k1\", \"v1\"), (\"a\", \"argument a is 1\"), (\"b\", \"Bar\"), (\"escaped1\", \"Bar{}\"), (\"escaped2\", \"{ \\\"a\\\": \\\"b\\\"}\")]\n"
stack backtrace:
   0: rust_begin_unwind
             at /rustc/24d2ac0b56fcbde13d827745f66e73efb1e17156/library/std/src/panicking.rs:665:5
   1: core::panicking::panic_fmt
             at /rustc/24d2ac0b56fcbde13d827745f66e73efb1e17156/library/core/src/panicking.rs:74:14
   2: core::panicking::assert_failed_inner
   3: core::panicking::assert_failed
             at /rustc/24d2ac0b56fcbde13d827745f66e73efb1e17156/library/core/src/panicking.rs:365:5
   4: lib::test_macro_properties::{{closure}}
             at ./tests/lib.rs:756:5
   5: core::ops::function::FnOnce::call_once
             at /rustc/24d2ac0b56fcbde13d827745f66e73efb1e17156/library/core/src/ops/function.rs:250:5
   6: serial_test::serial_code_lock::local_serial_core
             at /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/serial_test-3.1.1/src/serial_code_lock.rs:36:5
   7: lib::test_macro_properties
             at ./tests/lib.rs:697:1
   8: lib::test_macro_properties::{{closure}}
             at ./tests/lib.rs:698:27
   9: core::ops::function::FnOnce::call_once
             at /rustc/24d2ac0b56fcbde13d827745f66e73efb1e17156/library/core/src/ops/function.rs:250:5
  10: core::ops::function::FnOnce::call_once
             at /rustc/24d2ac0b56fcbde13d827745f66e73efb1e17156/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
test test_macro_properties ... FAILED

failures:

failures:
    test_macro_properties

test result: FAILED. 12 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.34s

#1 (comment)

@andylokandy andylokandy added the bug Something isn't working label Jul 23, 2024
@andylokandy andylokandy mentioned this issue Jul 23, 2024
5 tasks
@andylokandy
Copy link
Collaborator Author

andylokandy commented Aug 9, 2024

Seems not reproducible on github action recently.

@andylokandy andylokandy changed the title Unstable test on CI for macos Unstable test on CI Aug 12, 2024
@andylokandy andylokandy reopened this Aug 12, 2024
@qRoC
Copy link
Contributor

qRoC commented Sep 2, 2024

@tisonkun
Copy link
Collaborator

https://github.com/fast/fastrace/actions/runs/11733199886/job/32686969382

@andylokandy seems the failure cause is that we catch only async fn's trace but not fn's trace. Any thoughts on how to investigate deeper?

@andylokandy
Copy link
Collaborator Author

The hardest part is we cannot reproduce it locally...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants