Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounding boxes vector should be smaller and contiguous #65

Closed
fdrmrc opened this issue Jan 5, 2024 · 1 comment
Closed

Bounding boxes vector should be smaller and contiguous #65

fdrmrc opened this issue Jan 5, 2024 · 1 comment
Labels
design Related to code design enhancement New feature or request

Comments

@fdrmrc
Copy link
Owner

fdrmrc commented Jan 5, 2024

The minimal change in #64 highlights something serious. In order to map points back from real to unit space, we should not go through the many calls of the Mapping class, but just use BoundingBox::real_to_unit(). Surprisingly, this increased the computational times.

The reason is that the std::vector of bounding boxes is long as the number of elements of the underlying triangulation. This should really be contiguous.

@fdrmrc fdrmrc added enhancement New feature or request design Related to code design labels Jan 5, 2024
@fdrmrc
Copy link
Owner Author

fdrmrc commented Jan 7, 2024

Fixed by #66

@fdrmrc fdrmrc closed this as completed Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Related to code design enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant